Deprecate get_raw_response

Author: mkelley

astroquery/mpc/core.py

@@ -17,6 +17,7 @@
 from . import conf
 from ..utils import async_to_sync, class_or_instance
 from ..exceptions import InvalidQueryError, EmptyResponseError
+from astropy.utils.decorators import deprecated_renamed_argument
 
 __all__ = ['MPCClass']
 
@@ -763,6 +764,8 @@ def _args_to_ephemeris_payload(self, **kwargs):
         return request_args
 
     @class_or_instance
+    @deprecated_renamed_argument("get_raw_response", None, since="0.4.9",
+                                 alternative="async methods")
     def get_observations_async(self, targetid, *,
                                id_type=None,
                                get_mpcformat=False,
@@ -774,6 +777,11 @@ def get_observations_async(self, targetid, *,
         from the `Minor Planet Center observations database
         <https://minorplanetcenter.net/db_search>`_.
 
+        .. deprecated:: 0.4.9
+           The ``get_raw_response`` keyword argument is deprecated.  The
+           `~MPCClass.get_observationsephemerides_async` method will return a raw response.
+
+
         Parameters
         ----------
         targetid : int or str

astroquery/mpc/tests/test_mpc.py

@@ -415,10 +415,8 @@ def test_get_observations(patch_get):
     assert result['DEC'].unit == u.deg
     assert result['epoch'].unit == u.d
 
-    result = mpc.core.MPC.get_observations('12893',
-                                           get_raw_response=True)
-
-    assert result[0]['designation'] == "1998 QS55"
+    result = mpc.core.MPC.get_observations_async('12893')
+    assert result.json()[0]['designation'] == "1998 QS55"
 
     result = mpc.core.MPC.get_observations('12893',
                                            get_mpcformat=True)