- EmptyResponseError changed to NoResultsWarning when empty ephemeris table is retrieved

- Added remote test for ephemeris with moon phase and uncertainty
- Changes listed in CHANGES.rst

Author: jurezakrajsek

CHANGES.rst

@@ -12,6 +12,8 @@ mpc
 ^^^
 
 - Parse star catalog information when querying observations database [#2957]
+- Parse ephemeris with sky motion with three digit precision [#3019]
+- Raise NoResultWarining when empty ephemeris reponse is returned [#3019]
 
 linelists.cdms
 ^^^^^^^^^^^^^^

astroquery/mpc/core.py

@@ -16,8 +16,7 @@
 from ..query import BaseQuery
 from . import conf
 from ..utils import async_to_sync, class_or_instance
-from ..exceptions import InvalidQueryError, EmptyResponseError
-
+from ..exceptions import InvalidQueryError, EmptyResponseError, NoResultsWarning
 
 __all__ = ['MPCClass']
 
@@ -1064,7 +1063,7 @@ def _parse_result(self, result, **kwargs):
                 try:
                     i = text_table.index('\n', text_table.index('h m s')) + 1
                 except ValueError as e:
-                    raise EmptyResponseError(content)
+                    raise NoResultsWarning(content)
                 columns = text_table[:i]
                 data_start = columns.count('\n') - 1
             else:
@@ -1073,7 +1072,7 @@ def _parse_result(self, result, **kwargs):
                 try:
                     i = text_table.index('\n', text_table.index('JD_TT')) + 1
                 except ValueError as e:
-                    raise EmptyResponseError(content)
+                    raise NoResultsWarning(content)
                 columns = text_table[:i]
                 data_start = columns.count('\n') - 1
 
@@ -1181,7 +1180,6 @@ def _parse_result(self, result, **kwargs):
             else:
                 # convert from MPES string to Time
                 tab['JD'] = Time(tab['JD'], format='jd', scale='tt')
-            print(tab)
             return tab
 
         elif self.query_type == 'observations':

astroquery/mpc/tests/test_mpc_remote.py

@@ -1,7 +1,7 @@
 # Licensed under a 3-clause BSD style license - see LICENSE.rst
 import requests
 import pytest
-
+import astropy.units as u
 from astroquery.exceptions import InvalidQueryError
 from astroquery import mpc
 
@@ -78,6 +78,21 @@ def test_get_ephemeris_by_target(self, target):
         response = mpc.MPC.get_ephemeris(target)
         assert len(response) > 0
 
+    def test_get_ephemeris_Moon_phase(self):
+        result = mpc.core.MPC.get_ephemeris('2P', location='G37')
+        assert result['Moon phase'][0] >= 0
+
+    def test_get_ephemeris_Uncertainty(self):
+        # this test requires an object with uncertainties != N/A
+        result = mpc.core.MPC.get_ephemeris('2024 AA', start='2024-06-15')
+        assert result['Uncertainty 3sig'].quantity[0] > 0 * u.arcsec
+
+    def test_get_ephemeris_Moon_phase_and_Uncertainty(self):
+        # this test requires an object with uncertainties != N/A
+        result = mpc.core.MPC.get_ephemeris('2024 AA', location='G37', start='2024-06-15')
+        assert result['Moon phase'][0] >= 0
+        assert result['Uncertainty 3sig'].quantity[0] > 0 * u.arcsec
+
     def test_get_ephemeris_target_fail(self):
         # test that query failed
         with pytest.raises(InvalidQueryError):