Skip to content

Commit d44a3f9

Browse files
rickynilssonbsipocz
authored andcommitted
Add mock test of select
1 parent 2bb7e83 commit d44a3f9

File tree

1 file changed

+21
-7
lines changed

1 file changed

+21
-7
lines changed

astroquery/nasa_exoplanet_archive/tests/test_nasa_exoplanet_archive.py

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@
3636
TEST_DATA = pkg_resources.resource_filename(__name__, "data")
3737
RESPONSE_FILE = os.path.join(TEST_DATA, "responses.json")
3838

39-
# TAP supported: ps, pscomppars(, keplernames, k2names). API support: all others
40-
# TODO: add tables transitspec and emissionspec
39+
# API accessible tables will gradually transition to TAP service
40+
# Check https://exoplanetarchive.ipac.caltech.edu/docs/TAP/usingTAP.html for an up-to-date list
4141
API_TABLES = [
4242
("cumulative", dict(where="kepid=10601284")),
4343
("koi", dict(where="kepid=10601284")),
@@ -206,10 +206,6 @@ def mock_run_query(object_name="K2-18 b", table="pscomppars", select="pl_name,di
206206
assert object_name == "K2-18 b"
207207
assert table == "pscomppars"
208208
assert select == "pl_name,disc_year,discoverymethod,ra,dec"
209-
# result = AstroTable(rows=[('K2-18 b', 2015, 'Transit', 172.560141, 7.5878315)],
210-
# names=('pl_name', 'disc_year', 'discoverymethod', 'ra', 'dec'),
211-
# dtype=(str, int, str, float, float),
212-
# units=(None, None, None, u.deg, u.deg))
213209
result = PropertyMock()
214210
result = {'pl_name': 'K2-18 b', 'disc_year': 2015, 'discoverymethod': 'Transit', 'ra': [172.560141] * u.deg, 'dec': [7.5878315] * u.deg}
215211

@@ -232,7 +228,6 @@ def test_query_region():
232228
def mock_run_query(table="ps", select='pl_name,ra,dec', coordinates=SkyCoord(ra=172.56 * u.deg, dec=7.59 * u.deg), radius=1.0 * u.deg):
233229
assert table == "ps"
234230
assert select == 'pl_name,ra,dec'
235-
# assert coordinates == SkyCoord(ra=172.56 * u.deg, dec=7.59 * u.deg)
236231
assert radius == 1.0 * u.deg
237232
result = PropertyMock()
238233
result = {'pl_name': 'K2-18 b'}
@@ -281,3 +276,22 @@ def mock_run_query(table="ps", get_query_payload=True, select="count(*)", where=
281276
assert 'ps' in response['table']
282277
assert 'count(*)' in response['select']
283278
assert "disc_facility like '%TESS%'" in response['where']
279+
280+
281+
@patch('astroquery.nasa_exoplanet_archive.core.get_access_url',
282+
Mock(side_effect=lambda x: 'https://some.url'))
283+
@pytest.mark.skipif(not pyvo_OK, reason='not pyvo_OK')
284+
def test_select():
285+
nasa_exoplanet_archive = NasaExoplanetArchive()
286+
287+
def mock_run_query(table="ps", select=["hostname", "pl_name"], where="hostname='Kepler-11'", get_query_payload=True):
288+
assert table == "ps"
289+
assert select == ["hostname", "pl_name"]
290+
assert where == "hostname='Kepler-11'"
291+
assert get_query_payload
292+
payload = PropertyMock()
293+
payload = {'table': 'ps', 'select': 'hostname,pl_name','where': "hostname='Kepler-11'", 'format': 'ipac'}
294+
return payload
295+
nasa_exoplanet_archive.query_criteria = mock_run_query
296+
payload = nasa_exoplanet_archive.query_criteria()
297+
assert payload["select"] == "hostname,pl_name"

0 commit comments

Comments
 (0)