Error when filtering by nonexistent column

Author: snbianco

astroquery/mast/tests/test_mast.py

@@ -374,10 +374,6 @@ def test_missions_filter_products(patch_post):
     filtered = mast.MastMissions.filter_products(products, extension='fits')
     assert len(filtered) > 0
 
-    # Filter by non-existing column
-    with pytest.warns(InputWarning):
-        mast.MastMissions.filter_products(products, invalid=True)
-
     # Numeric filtering
     # Single integer value
     filtered = mast.MastMissions.filter_products(products, size=11520)
@@ -412,6 +408,10 @@ def test_missions_filter_products(patch_post):
         # Invalid filter value
         mast.MastMissions.filter_products(products, size='invalid')
 
+    # Error when filtering by non-existing column
+    with pytest.raises(InvalidQueryError, match="Column 'non_existing' not found in product table."):
+        mast.MastMissions.filter_products(products, non_existing='value')
+
 
 def test_missions_download_products(patch_post, tmp_path):
     # Check string input
@@ -720,10 +720,6 @@ def test_observations_filter_products(patch_post):
     filtered = mast.Observations.filter_products(products, extension='fits')
     assert len(filtered) > 0
 
-    # Filter by non-existing column
-    with pytest.warns(InputWarning):
-        mast.Observations.filter_products(products, invalid=True)
-
     # Numeric filtering
     filtered = mast.Observations.filter_products(products, size='<50000')
     assert all(filtered['size'] < 50000)
@@ -732,6 +728,10 @@ def test_observations_filter_products(patch_post):
     with pytest.raises(InvalidQueryError, match="Could not parse numeric filter 'invalid' for column 'size'"):
         filtered = mast.Observations.filter_products(products, size='invalid')
 
+    # Filter by non-existing column
+    with pytest.raises(InvalidQueryError, match="Column 'invalid' not found in product table."):
+        mast.Observations.filter_products(products, invalid=True)
+
 
 def test_observations_download_products(patch_post, tmpdir):
     # actually download the products

astroquery/mast/tests/test_mast_remote.py

@@ -297,11 +297,6 @@ def test_missions_filter_products(self):
         assert isinstance(filtered, Table)
         assert all(filtered['category'] == 'CALIBRATED')
 
-        # Filter by non-existing column
-        with pytest.warns(InputWarning):
-            filtered = MastMissions.filter_products(products,
-                                                    invalid=True)
-
     def test_missions_download_products(self, tmp_path):
         def check_filepath(path):
             assert path.is_file()

astroquery/mast/utils.py

@@ -416,8 +416,7 @@ def apply_column_filters(products, filters):
     # Applying column-based filters
     for colname, vals in filters.items():
         if colname not in products.colnames:
-            warnings.warn(f"Column '{colname}' not found in product table.", InputWarning)
-            continue
+            raise InvalidQueryError(f"Column '{colname}' not found in product table.")
 
         col_data = products[colname]
         # If the column is an integer or float, accept numeric filters