Skip to content

Commit e3dd3de

Browse files
authored
Merge pull request #753 from segasai/fix_simbad_radius1
fix parsing of radius option in Simbad queries.
2 parents 6442d2a + 4e9bcaa commit e3dd3de

File tree

2 files changed

+11
-12
lines changed

2 files changed

+11
-12
lines changed

astroquery/simbad/core.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -811,13 +811,11 @@ def _parse_radius(radius):
811811
index = 2 # use arcseconds when radius smaller than 1 arcsecond
812812
unit = ('d', 'm', 's')[index]
813813
if unit == 'd':
814-
return str(int(angle.degree)) + unit
814+
return str(angle.degree) + unit
815815
if unit == 'm':
816-
sec_to_min = abs(angle.dms[2]) * u.arcsec.to(u.arcmin)
817-
total_min = abs(angle.dms[1]) + sec_to_min
818-
return str(total_min) + unit
816+
return str(angle.arcmin) + unit
819817
if unit == 's':
820-
return str(abs(angle.dms[2])) + unit
818+
return str(angle.arcsec) + unit
821819
except (coord.errors.UnitsError, AttributeError):
822820
raise ValueError("Radius specified incorrectly")
823821

astroquery/simbad/tests/test_simbad.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -69,12 +69,13 @@ def post_mockreturn(url, data, timeout, **kwargs):
6969

7070

7171
@pytest.mark.parametrize(('radius', 'expected_radius'),
72-
[('5d0m0s', '5d'),
73-
('5d', '5d'),
74-
('5.0d', '5d'),
75-
(5 * u.deg, '5d'),
76-
(5.0 * u.deg, '5d'),
77-
(0.432 * u.deg, '25.92m'),
72+
[('5d0m0s', '5.0d'),
73+
('5d', '5.0d'),
74+
('5.0d', '5.0d'),
75+
(5 * u.deg, '5.0d'),
76+
(5.0 * u.deg, '5.0d'),
77+
(1.2 * u.deg, '1.2d'),
78+
(0.5 * u.deg, '30.0m'),
7879
('0d1m12s', '1.2m'),
7980
(0.003 * u.deg, '10.8s'),
8081
('0d0m15s', '15.0s')
@@ -135,7 +136,7 @@ def test_parse_result():
135136
("\nvotable {" + votable_fields + "}\n"
136137
"votable open\n"
137138
"query coo 5:35:17.3 -80:52:00 "
138-
"radius=5d frame=ICRS equi=2000.0 epoch=J2000 \n"
139+
"radius=5.0d frame=ICRS equi=2000.0 epoch=J2000 \n"
139140
"votable close")),
140141
(["m [0-9]"], dict(wildcard=True,
141142
caller='query_object_async'),

0 commit comments

Comments
 (0)