update remote tests and test data

Author: Alvaro Arroyo Parejo

astroquery/esa/neocc/test/data/esa_special_risk_list

@@ -1,4 +1,6 @@
-Last Update: 2021-10-04 05:49 UTC
+Last Update: 2022-08-19 08:03 UTC
             Object         |    Diameter    |             VI Max                                   |
  Num/des.       Name       |   m  |   *=Y   |      Date/Time   |  IP max  | PS max |TS  | Vel km/s |
 AAAAAAAAA AAAAAAAAAAAAAAAA | NNNN |    A    | YYYY-MM-DD HH:MM | EEEEEEEE | NNN.NN | NN |  NNN.NN  |
+101955               Bennu |  484 |         | 2182-09-24 20:24 |  3.70E-4 |  -1.59 |    |   12.68  |
+29075               1950DA | 1300 |         | 2880-03-16 23:48 |  1.96E-5 |  -2.13 |    |   17.99  |

astroquery/esa/neocc/test/data/past_impactors_list

@@ -0,0 +1,7 @@
+Last Update: 2022-04-04 10:00 UTC
+  Object designator  |  Diameter in m  |  Impact date/time in UTC  |  Impact Velocity in km/s  |  Estimated energy in Mt  |  Measured energy in Mt  |
+       2022EB5       |      1.9*       |    2022-03-11 21:22:00    |           18.53           |         2.96E-4          |        4.00E-3          |
+       2019MO        |       5*        |    2019-06-22 21:30:00    |           16.34           |         3.82E-3          |        6.00E-3          |
+       2018LA        |      2.8*       |    2018-06-02 16:44:00    |           16.98           |         8.90E-4          |        9.80E-4          |
+       2014AA        |      2.3*       |    2014-01-02 02:30:00    |           11.97           |         2.44E-4          |           n/a           |
+       2008TC3       |       3*        |    2008-10-07 02:45:00    |           11.77           |         6.77E-4          |        1.00E-3          |

astroquery/esa/neocc/test/test_neocc_remote.py

@@ -7,19 +7,20 @@
 * Property: European Space Agency (ESA)
 * Developed by: Elecnor Deimos
 * Author: C. Álvaro Arroyo Parejo
-* Date: 02-11-2021
+* Date: 21-08-2022
 
-© Copyright [European Space Agency][2021]
+© Copyright [European Space Agency][2022]
 All rights reserved
 """
 
-
 import io
 import os
 import re
-
 import random
 import pytest
+import astropy
+
+from astropy.table import Table
 import pandas as pd
 import pandas.testing as pdtesting
 import pandas.api.types as ptypes
@@ -28,8 +29,6 @@
 from astroquery.esa.neocc.__init__ import conf
 from astroquery.esa.neocc import neocc, lists, tabs
 
-import astropy
-
 # Import BASE URL and TIMEOUT
 API_URL = conf.API_URL
 DATA_DIR = os.path.join(os.path.dirname(__file__), 'data')
@@ -52,7 +51,7 @@ class TestLists:
         "priority_list": 'esa_priority_neo_list',
         "priority_list_faint": 'esa_faint_neo_list',
         "close_encounter" : 'close_encounter2.txt',
-        "impacted_objects" : 'impactedObjectsList.txt',
+        "impacted_objects" : 'past_impactors_list',
         "neo_catalogue_current" : 'neo_kc.cat',
         "neo_catalogue_middle" : 'neo_km.cat'
         }
@@ -127,8 +126,11 @@ def test_parse_list(self):
                                      verify=VERIFICATION).content
             # Decode the data using UTF-8
             data_list_d = io.StringIO(data_list.decode('utf-8'))
-
-            assert isinstance(lists.parse_list(url, data_list_d),
+            if url == 'impacted_objects':
+                assert isinstance(lists.parse_list(url, data_list_d),
+                                                    Table)
+            else:
+                assert isinstance(lists.parse_list(url, data_list_d),
                                                     pd.DataFrame)
         # Invalid inputs
         bad_names = ["ASedfe", "%&$", "ÁftR+", 154]
@@ -222,9 +224,22 @@ def test_parse_risk(self):
                         new_list['Date/Time'])
 
             else:
-            # Currently risk special list is empty
-                assert new_list.empty
+             # Assert dataframe is not empty, columns names
+                assert not new_list.empty
                 assert (new_list.columns == risk_special_columns).all()
+            # Assert columns data types
+                # Floats
+                float_cols = ['IP max', 'PS max', 'Vel in km/s']
+                assert all(ptypes.is_float_dtype(new_list[cols1])\
+                    for cols1 in float_cols)
+                # int64
+                int_cols = ['Diameter in m']
+                assert all(ptypes.is_int64_dtype(new_list[cols2])\
+                    for cols2 in int_cols)
+                # Object
+                object_cols = ['Object Name', '*=Y', 'TS']
+                assert all(ptypes.is_object_dtype(new_list[cols3])\
+                    for cols3 in object_cols)
 
 
     def test_parse_clo(self):
@@ -254,7 +269,7 @@ def test_parse_clo(self):
             # Assert dataframe is not empty, columns names and length
             assert not new_list.empty
             assert (new_list.columns == close_columns).all()
-            assert len(new_list.index) > 100
+            assert len(new_list.index) > 10
             # Assert Connection Error. In case of internal server error
             # the request provided an empty file
             foo_error = io.StringIO('This site cant be reached\n'
@@ -383,15 +398,11 @@ def test_parse_impacted(self):
         # Parse using parse_nea
         new_list = lists.parse_impacted(data_list_d)
         # Assert is a pandas DataFrame
-        assert isinstance(new_list, pd.DataFrame)
+        assert isinstance(new_list, Table)
         # Assert dataframe is not empty and length
-        assert not new_list.empty
-        assert len(new_list.index) < 100
-        # Assert columns data types
-        # Object
-        assert ptypes.is_object_dtype(new_list[0])
-        # Datetime
-        assert ptypes.is_datetime64_ns_dtype(new_list[1])
+        # Assert dataframe is not empty, columns names and length
+        assert len(new_list) != 0
+        assert len(new_list) < 100
 
 
     def test_parse_neo_catalogue(self):
@@ -460,14 +471,16 @@ def test_get_object_url(self):
                        'observations', 'orbit_properties', '&cefrgfe',
                        4851]
         # Possible additional argument
+        orbital_element = ['keplerian', 'equinoctial']
         orbit_epoch = ['present', 'middle']
         # Iterate to obtain all possible urls
         for tab in object_tabs:
             if tab == 'orbit_properties':
-                for epoch in orbit_epoch:
-                    with pytest.raises(ValueError):
-                        tabs.get_object_url(rnd_object, tab,
-                        orbital_elements=None, orbit_epoch=epoch)
+                for element in orbital_element:
+                    for epoch in orbit_epoch:
+                        with pytest.raises(ValueError):
+                            tabs.get_object_url(rnd_object, tab,
+                            orbital_elements=None, orbit_epoch=epoch)
             elif tab in ['&cefrgfe', 4851]:
                 with pytest.raises(KeyError):
                     tabs.get_object_url(rnd_object, tab)