Merge pull request #1874 from tinumide/issue-1803

changed warning to error for authentication failure

Author: bsipocz

CHANGES.rst

@@ -156,6 +156,13 @@ sdss
 - Optional keyword arguments are now keyword only. [#2477, #2532]
 
 
+mast
+^^^^
+
+- Changed warning to error for authentication failure. [#1874]
+
+
+
 Infrastructure, Utility and Other Changes and Additions
 -------------------------------------------------------
 

astroquery/mast/auth.py

@@ -9,13 +9,12 @@
 
 import os
 import keyring
-import warnings
 
 from getpass import getpass
 
 from astroquery import log
 
-from ..exceptions import AuthenticationWarning
+from ..exceptions import LoginError
 
 from . import conf
 
@@ -82,10 +81,8 @@ def login(self, token=None, store_token=False, reenter_token=False):
         if not info["anon"]:
             log.info("MAST API token accepted, welcome {}".format(info["attrib"].get("display_name")))
         else:
-            warn_msg = ("MAST API token invalid!\n"
-                        "To make create a new API token visit to following link: " +
-                        self.AUTH_URL)
-            warnings.warn(warn_msg, AuthenticationWarning)
+            raise LoginError("MAST API token invalid!\n To create a new API token"
+                             "visit to following link: " + self.AUTH_URL)
 
         return not info["anon"]