this commit includes debug work: for some reason, the warning I'm

expecting to be raised isn't being raised.  I could use help here, but
now it's telecon time (squash this commit away later)

Author: keflavich

astroquery/alma/core.py

@@ -750,6 +750,7 @@ def download_files(self, files, savedir=None, cache=True,
 
             if verify_only:
                 existing_file_length = os.stat(filename).st_size
+                print(f"{filename}: {existing_file_length}")
                 if 'content-length' in check_filename.headers:
                     length = int(check_filename.headers['content-length'])
                     if length == 0:
@@ -760,8 +761,11 @@ def download_files(self, files, savedir=None, cache=True,
                         log.info(f"Found cached file {filename} with size {existing_file_length} < expected "
                                  f"size {length}.  The download should be continued.")
                     elif existing_file_length > length:
+                        print("Issuing a warning")
                         warnings.warn(f"Found cached file {filename} with size {existing_file_length} > expected "
                                       f"size {length}.  The download is likely corrupted.")
+                    else:
+                        raise ValueError("It should not be possible to reach this state.")
                 else:
                     warnings.warn(f"Could not verify {url} because it has no 'content-length'")
 

astroquery/alma/tests/test_alma_remote.py

@@ -686,12 +686,15 @@ def test_verify_html_file(alma, caplog):
     with open(local_filepath, 'ab') as fh:
         fh.write(b"Extra Text")
 
+    print("Trying the failed version now")
     caplog.clear()
-    with warnings.catch_warnings() as ww:
+    with warnings.catch_warnings(record=True) as ww:
         result = alma.download_files(['https://almascience.nao.ac.jp/dataPortal/member.uid___A001_X1284_X1353.qa2_report.html'], verify_only=True)
         assert result
         length = 66336
         existing_file_length = length + 10
+        print(f"WARNING: {str(ww)}")
+        print(f"caplog: {caplog.text}")
         assert f"Found cached file {local_filepath} with size {existing_file_length} > expected size {length}.  The download is likely corrupted." in str(ww)
 
     # manipulate the file: make it small