Fix virtualenv command to use correct python executable path and changed systemd service under ~/.config (#256)

* Fix virtualenv command to use correct python executable path

The virtualenv --python argument was incorrectly using PYTHON_VERSION (e.g., '3.10')
instead of the PYTHON executable path. This caused venv creation to fail on systems
where the version string is not a valid command, leading to service startup errors.

* Address review comments: standardize SERVICE_INSTALL_DIR_PATH and optimize PYTHON_VERSION assignment

Author: s-badran

README.md

@@ -74,13 +74,12 @@ INSTALL_DIR_PATH="/usr/share/asus-numberpad-driver"
 CONFIG_FILE_DIR_PATH="$INSTALL_DIR_PATH"
 CONFIG_FILE_NAME="numberpad_dev"
 LOGS_DIR_PATH="/var/log/asus-numberpad-driver" # only for install and uninstall logs
-SERVICE_INSTALL_DIR_PATH="/usr/lib/systemd/user"
+SERVICE_INSTALL_DIR_PATH="$HOME/.config/systemd/user"
 INSTALL_UDEV_DIR_PATH="/usr/lib/udev"
 
 # e.g. for BazziteOS (https://github.com/asus-linux-drivers/asus-numberpad-driver/issues/198)
 $ INSTALL_DIR_PATH="/home/$USER/.local/share/asus-numberpad-driver"\
 INSTALL_UDEV_DIR_PATH="/etc/udev"\
-SERVICE_INSTALL_DIR_PATH="/home/$USER/.config/systemd/user/"\
 bash install.sh
 ```
 
@@ -250,13 +249,12 @@ INSTALL_DIR_PATH="/usr/share/asus-numberpad-driver"
 CONFIG_FILE_DIR_PATH="$INSTALL_DIR_PATH"
 CONFIG_FILE_NAME="numberpad_dev"
 LOGS_DIR_PATH="/var/log/asus-numberpad-driver" # only for install and uninstall logs
-SERVICE_INSTALL_DIR_PATH="/usr/lib/systemd/user"
+SERVICE_INSTALL_DIR_PATH="$HOME/.config/systemd/user"
 INSTALL_UDEV_DIR_PATH="/usr/lib/udev"
 
 # e.g. for BazziteOS (https://github.com/asus-linux-drivers/asus-numberpad-driver/issues/198)
 $ INSTALL_DIR_PATH="/home/$USER/.local/share/asus-numberpad-driver"\
 INSTALL_UDEV_DIR_PATH="/etc/udev/"\
-SERVICE_INSTALL_DIR_PATH="/home/$USER/.config/systemd/user/"\
 bash uninstall.sh
 ```
 

install.sh

@@ -194,15 +194,15 @@ LOGS_INSTALL_LOG_FILE_PATH="$LOGS_DIR_PATH/$LOGS_INSTALL_LOG_FILE_NAME"
     fi
 
     # xcffib (https://pypi.org/project/xcffib/) requires python >=3.10
-    PYTHON_VERSION=$($PYTHON -c "import sys; print('.'.join(map(str, sys.version_info[:2])))")
     if ! $PYTHON -c "import sys; sys.exit(0 if sys.version_info >= (3,10) else 1)"; then
+        PYTHON_VERSION=$($PYTHON -c "import sys; print('.'.join(map(str, sys.version_info[:2])))")
         echo "Python >= 3.10 is required (found $PYTHON_VERSION)."
         echo "Please install Python 3.10 or higher before continuing."
         exit 1
     fi
 
     # create Python3 virtual environment
-    virtualenv --python="$PYTHON_VERSION" $INSTALL_DIR_PATH/.env
+    virtualenv --python="$PYTHON" $INSTALL_DIR_PATH/.env
     source $INSTALL_DIR_PATH/.env/bin/activate
     pip3 install --upgrade pip
     pip3 install --upgrade setuptools

install_service.sh

@@ -13,7 +13,7 @@ if [ -z "$LOGS_DIR_PATH" ]; then
     LOGS_DIR_PATH="/var/log/asus-numberpad-driver"
 fi
 if [ -z "$SERVICE_INSTALL_DIR_PATH" ]; then
-    SERVICE_INSTALL_DIR_PATH="/usr/lib/systemd/user"
+    SERVICE_INSTALL_DIR_PATH="$HOME/.config/systemd/user"
 fi
 
 echo "Systemctl service"
@@ -105,12 +105,14 @@ case "$RESPONSE" in [yY][eE][sS]|[yY])
 
     echo
 
+    mkdir -p "$SERVICE_INSTALL_DIR_PATH"
+
     if [ "$XDG_SESSION_TYPE" == "x11" ]; then
-        cat "$SERVICE_X11_FILE_PATH" | INSTALL_DIR_PATH=$INSTALL_DIR_PATH LAYOUT_NAME=$LAYOUT_NAME CONFIG_FILE_DIR_PATH="$CONFIG_FILE_DIR_PATH/" DISPLAY=$DISPLAY XAUTHORITY=$XAUTHORITY XDG_RUNTIME_DIR=$XDG_RUNTIME_DIR XDG_SESSION_TYPE=$XDG_SESSION_TYPE DBUS_SESSION_BUS_ADDRESS=$DBUS_SESSION_BUS_ADDRESS ERROR_LOG_FILE_PATH=$ERROR_LOG_FILE_PATH envsubst '$INSTALL_DIR_PATH $LAYOUT_NAME $CONFIG_FILE_DIR_PATH $DISPLAY $XAUTHORITY $XDG_RUNTIME_DIR $XDG_SESSION_TYPE $DBUS_SESSION_BUS_ADDRESS $ERROR_LOG_FILE_PATH' | sudo tee "$SERVICE_INSTALL_DIR_PATH/$SERVICE_INSTALL_FILE_NAME" >/dev/null
+        cat "$SERVICE_X11_FILE_PATH" | INSTALL_DIR_PATH=$INSTALL_DIR_PATH LAYOUT_NAME=$LAYOUT_NAME CONFIG_FILE_DIR_PATH="$CONFIG_FILE_DIR_PATH/" DISPLAY=$DISPLAY XAUTHORITY=$XAUTHORITY XDG_RUNTIME_DIR=$XDG_RUNTIME_DIR XDG_SESSION_TYPE=$XDG_SESSION_TYPE DBUS_SESSION_BUS_ADDRESS=$DBUS_SESSION_BUS_ADDRESS ERROR_LOG_FILE_PATH=$ERROR_LOG_FILE_PATH envsubst '$INSTALL_DIR_PATH $LAYOUT_NAME $CONFIG_FILE_DIR_PATH $DISPLAY $XAUTHORITY $XDG_RUNTIME_DIR $XDG_SESSION_TYPE $DBUS_SESSION_BUS_ADDRESS $ERROR_LOG_FILE_PATH' | tee "$SERVICE_INSTALL_DIR_PATH/$SERVICE_INSTALL_FILE_NAME" >/dev/null
     else
         echo "Unfortunatelly you will not be able use feature: Disabling Touchpad (e.g. Fn+special key) disables NumberPad aswell, at this moment is supported only X11"
         # DISPLAY=$DISPLAY for Xwayland
-        cat "$SERVICE_WAYLAND_FILE_PATH" | INSTALL_DIR_PATH=$INSTALL_DIR_PATH LAYOUT_NAME=$LAYOUT_NAME CONFIG_FILE_DIR_PATH="$CONFIG_FILE_DIR_PATH/" DISPLAY=$DISPLAY XDG_RUNTIME_DIR=$XDG_RUNTIME_DIR XDG_SESSION_TYPE=$XDG_SESSION_TYPE DBUS_SESSION_BUS_ADDRESS=$DBUS_SESSION_BUS_ADDRESS ERROR_LOG_FILE_PATH=$ERROR_LOG_FILE_PATH envsubst '$INSTALL_DIR_PATH $LAYOUT_NAME $CONFIG_FILE_DIR_PATH $DISPLAY $XDG_RUNTIME_DIR $XDG_SESSION_TYPE $DBUS_SESSION_BUS_ADDRESS $ERROR_LOG_FILE_PATH' | sudo tee "$SERVICE_INSTALL_DIR_PATH/$SERVICE_INSTALL_FILE_NAME" >/dev/null
+        cat "$SERVICE_WAYLAND_FILE_PATH" | INSTALL_DIR_PATH=$INSTALL_DIR_PATH LAYOUT_NAME=$LAYOUT_NAME CONFIG_FILE_DIR_PATH="$CONFIG_FILE_DIR_PATH/" DISPLAY=$DISPLAY XDG_RUNTIME_DIR=$XDG_RUNTIME_DIR XDG_SESSION_TYPE=$XDG_SESSION_TYPE DBUS_SESSION_BUS_ADDRESS=$DBUS_SESSION_BUS_ADDRESS ERROR_LOG_FILE_PATH=$ERROR_LOG_FILE_PATH envsubst '$INSTALL_DIR_PATH $LAYOUT_NAME $CONFIG_FILE_DIR_PATH $DISPLAY $XDG_RUNTIME_DIR $XDG_SESSION_TYPE $DBUS_SESSION_BUS_ADDRESS $ERROR_LOG_FILE_PATH' | tee "$SERVICE_INSTALL_DIR_PATH/$SERVICE_INSTALL_FILE_NAME" >/dev/null
     fi
 
     if [[ $? != 0 ]]; then

uninstall_service.sh

@@ -4,7 +4,7 @@ source non_sudo_check.sh
 
 # ENV VARS
 if [ -z "$SERVICE_INSTALL_DIR_PATH" ]; then
-    SERVICE_INSTALL_DIR_PATH="/usr/lib/systemd/user"
+    SERVICE_INSTALL_DIR_PATH="$HOME/.config/systemd/user"
 fi
 
 SERVICE_INSTALL_FILE_NAME="[email protected]"