Fix I2C permission issue on Fedora (#254)

- Change udev rules path from /usr/lib/udev to /etc/udev for proper precedence
- Add KERNEL match to i2c-dev udev rule for better device detection
- Enhance error handling in numberpad.py for permission errors
- Ensure consistent INSTALL_UDEV_DIR_PATH across all scripts
- Add directory creation for robustness in install scripts

Author: s-badran

asus-numberpad-driver.code-workspace

@@ -0,0 +1,8 @@
+{
+	"folders": [
+		{
+			"path": "."
+		}
+	],
+	"settings": {}
+}

install_external_keyboard_toggle.sh

@@ -13,7 +13,7 @@ if [ -z "$CONFIG_FILE_NAME" ]; then
     CONFIG_FILE_NAME="numberpad_dev"
 fi
 if [ -z "$INSTALL_UDEV_DIR_PATH" ]; then
-    INSTALL_UDEV_DIR_PATH="/usr/lib/udev"
+    INSTALL_UDEV_DIR_PATH="/etc/udev"
 fi
 
 CONFIG_FILE_PATH="$CONFIG_FILE_DIR_PATH/$CONFIG_FILE_NAME"
@@ -38,6 +38,8 @@ case "$RESPONSE" in [yY][eE][sS]|[yY])
 
     echo
 
+    sudo mkdir -p $INSTALL_UDEV_DIR_PATH/rules.d
+
     cat "udev/90-numberpad-external-keyboard.rules" | INSTALL_DIR_PATH=$INSTALL_DIR_PATH envsubst '$INSTALL_DIR_PATH' | sudo tee "$INSTALL_UDEV_DIR_PATH/rules.d/90-numberpad-external-keyboard.rules" >/dev/null
 
     if [[ $? != 0 ]]; then

install_power_supply_saver.sh

@@ -13,7 +13,7 @@ if [ -z "$CONFIG_FILE_NAME" ]; then
     CONFIG_FILE_NAME="numberpad_dev"
 fi
 if [ -z "$INSTALL_UDEV_DIR_PATH" ]; then
-    INSTALL_UDEV_DIR_PATH="/usr/lib/udev"
+    INSTALL_UDEV_DIR_PATH="/etc/udev"
 fi
 
 CONFIG_FILE_PATH="$CONFIG_FILE_DIR_PATH/$CONFIG_FILE_NAME"
@@ -32,6 +32,8 @@ case "$RESPONSE" in [yY][eE][sS]|[yY])
 
     echo
 
+    sudo mkdir -p $INSTALL_UDEV_DIR_PATH/rules.d
+
     cat "udev/80-numberpad-power-supply.rules" | INSTALL_DIR_PATH=$INSTALL_DIR_PATH envsubst '$INSTALL_DIR_PATH' | sudo tee "$INSTALL_UDEV_DIR_PATH/rules.d/80-numberpad-power-supply.rules" >/dev/null
 
     if [[ $? != 0 ]]; then

install_user_groups.sh

@@ -4,7 +4,7 @@ source non_sudo_check.sh
 
 # ENV VARS
 if [ -z "$INSTALL_UDEV_DIR_PATH" ]; then
-    INSTALL_UDEV_DIR_PATH="/usr/lib/udev"
+    INSTALL_UDEV_DIR_PATH="/etc/udev"
 fi
 
 sudo groupadd "input"
@@ -42,10 +42,11 @@ fi
 
 # https://github.com/asus-linux-drivers/asus-numberpad-driver/issues/231
 sudo mkdir -p /etc/modules-load.d
+sudo mkdir -p $INSTALL_UDEV_DIR_PATH/rules.d
 
 echo 'KERNEL=="uinput", GROUP="uinput", MODE="0660"' | sudo tee $INSTALL_UDEV_DIR_PATH/rules.d/99-asus-numberpad-driver-uinput.rules >/dev/null
 echo 'uinput' | sudo tee /etc/modules-load.d/uinput-asus-numberpad-driver.conf >/dev/null
-echo 'SUBSYSTEM=="i2c-dev", GROUP="i2c", MODE="0660"' | sudo tee $INSTALL_UDEV_DIR_PATH/rules.d/99-asus-numberpad-driver-i2c-dev.rules >/dev/null
+echo 'SUBSYSTEM=="i2c-dev", KERNEL=="i2c-[0-9]*", GROUP="i2c", MODE="0660"' | sudo tee $INSTALL_UDEV_DIR_PATH/rules.d/99-asus-numberpad-driver-i2c-dev.rules >/dev/null
 echo "i2c-dev" | sudo tee /etc/modules-load.d/i2c-dev-asus-numberpad-driver.conf >/dev/null
 
 if [[ $? != 0 ]]; then

numberpad.py

@@ -736,6 +736,8 @@ def send_value_to_touchpad_via_i2c(value):
             data = [0x05, 0x00, 0x3d, 0x03, 0x06, 0x00, 0x07, 0x00, 0x0d, 0x14, 0x03, int(value, 16), 0xad]
             msg = i2c_msg.write(device_addr, data)
             bus.i2c_rdwr(msg)
+    except PermissionError:
+        log.error('Permission denied during I2C communication. Please ensure you are in the "i2c" group.')
     except Exception as e:
         log.error('Error during sending via i2c: \"%s\"', e)
 
@@ -1067,8 +1069,11 @@ def get_compose_key_start_events_for_unicode_string(reset_udev = True):
     bus = SMBus()
     bus.open(int(device_id))
     bus.close()
-except:
-    log.error("Can't open the I2C bus connection (id: %s)", device_id)
+except PermissionError:
+    log.error("Permission denied when opening I2C bus (id: %s). Please ensure you are in the 'i2c' group and that udev rules are applied. Try logging out and back in, or reboot.", device_id)
+    sys.exit(1)
+except Exception as e:
+    log.error("Can't open the I2C bus connection (id: %s): %s", device_id, e)
     sys.exit(1)
 
 

uninstall.sh

@@ -25,7 +25,7 @@ shopt -s extglob
     INSTALL_DIR_PATH="/usr/share/asus-numberpad-driver"
   fi
   if [ -z "$INSTALL_UDEV_DIR_PATH" ]; then
-    INSTALL_UDEV_DIR_PATH="/usr/lib/udev/"
+    INSTALL_UDEV_DIR_PATH="/etc/udev"
   fi
   if [ -z "$CONFIG_FILE_DIR_PATH" ]; then
 	  CONFIG_FILE_DIR_PATH="$INSTALL_DIR_PATH"

uninstall_external_keyboard_toggle.sh

@@ -7,7 +7,7 @@ if [ -z "$INSTALL_DIR_PATH" ]; then
     INSTALL_DIR_PATH="/usr/share/asus-numberpad-driver"
 fi
 if [ -z "$INSTALL_UDEV_DIR_PATH" ]; then
-    INSTALL_UDEV_DIR_PATH="/usr/lib/udev"
+    INSTALL_UDEV_DIR_PATH="/etc/udev"
 fi
 
 sudo rm -f "$INSTALL_DIR_PATH/udev/external_keyboard_is_connected.sh"

uninstall_power_supply_saver.sh

@@ -7,7 +7,7 @@ if [ -z "$INSTALL_DIR_PATH" ]; then
     INSTALL_DIR_PATH="/usr/share/asus-numberpad-driver"
 fi
 if [ -z "$INSTALL_UDEV_DIR_PATH" ]; then
-    INSTALL_UDEV_DIR_PATH="/usr/lib/udev"
+    INSTALL_UDEV_DIR_PATH="/etc/udev"
 fi
 
 sudo rm -f "$INSTALL_DIR_PATH/udev/power_supply_is_ac.sh"