Skip to content

Commit 82973ae

Browse files
committed
commits_table: fix '...' commit message expand box
RenderCommitMessageLinkSubject should be called with .Summary, not .Message, since it strips all but the first line and loses the </a> that's needed for the HTML to be valid. As a result, the '...' button is a link to the full commit and behaves badly.
1 parent 5e47ec1 commit 82973ae

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

templates/repo/commits_table.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
<td class="message">
7373
<span class="message-wrapper">
7474
{{ $commitLink:= printf "%s/%s/%s/commit/%s" AppSubUrl $.Username $.Reponame .ID }}
75-
<span class="commit-summary has-emoji{{if gt .ParentCount 1}} grey text{{end}}" title="{{.Summary}}">{{RenderCommitMessageLinkSubject .Message $.RepoLink $commitLink $.Repository.ComposeMetas}}</span>
75+
<span class="commit-summary has-emoji grey text" title="{{.Summary}}">{{RenderCommitMessageLinkSubject .Summary $.RepoLink $commitLink $.Repository.ComposeMetas}}</span>
7676
</span>
7777
{{if IsMultilineCommitMessage .Message}}
7878
<button class="basic compact mini ui icon button commit-button"><i class="ellipsis horizontal icon"></i></button>

0 commit comments

Comments
 (0)