Stop using HttpResponse::stream method

Author: jderusse

src/Core/CHANGELOG.md

@@ -2,11 +2,15 @@
 
 ## NOT RELEASED
 
+### Fixed
+
+- Buffer the response in temporary file to avoid issues when stream is used by another request's body
+
 ## 1.27.1
 
 ### Fixed
 
-- SignerV4: fix sort of query parameters to build correct canoncal query string 
+- SignerV4: fix sort of query parameters to build correct canoncal query string
 
 ## 1.27.0
 

src/Core/src/Response.php

@@ -17,7 +17,6 @@
 use AsyncAws\Core\Exception\LogicException;
 use AsyncAws\Core\Exception\RuntimeException;
 use AsyncAws\Core\Exception\UnparsableResponse;
-use AsyncAws\Core\Stream\ResponseBodyResourceStream;
 use AsyncAws\Core\Stream\ResponseBodyStream;
 use AsyncAws\Core\Stream\ResultStream;
 use Psr\Log\LoggerInterface;
@@ -288,7 +287,7 @@ final public static function wait(iterable $responses, ?float $timeout = null, b
      * @return array{
      *                resolved: bool,
      *                body_downloaded: bool,
-     *                response: \Symfony\Contracts\HttpClient\ResponseInterface,
+     *                response: ResponseInterface,
      *                status: int,
      *                }
      */
@@ -369,10 +368,6 @@ public function toStream(): ResultStream
     {
         $this->resolve();
 
-        if (\is_callable([$this->httpResponse, 'toStream'])) {
-            return new ResponseBodyResourceStream($this->httpResponse->toStream());
-        }
-
         if ($this->streamStarted) {
             throw new RuntimeException('Can not create a ResultStream because the body started being downloaded. The body was started to be downloaded in Response::wait()');
         }

src/Service/S3/CHANGELOG.md

@@ -6,6 +6,10 @@
 
 - AWS api-change: Expires's property and its getters/setters switched from `\DateTimeImmutable` to `string`.
 
+### Changed
+
+- Add test to ensure a response's body can be streamed to another request's body.
+
 ## 2.10.0
 
 ### Added

src/Service/S3/tests/Integration/S3ClientTest.php

@@ -1008,6 +1008,25 @@ public function testUploadPartCopy(): void
         self::assertEquals(200, $result->info()['status']);
     }
 
+    public function testStreamToStream(): void
+    {
+        $client = $this->getClient();
+
+        $client->putObject([
+            'Bucket' => 'foo',
+            'Key' => 'bar',
+            'Body' => 'content',
+        ])->resolve();
+
+        $client->putObject([
+            'Bucket' => 'foo',
+            'Key' => 'bar2',
+            'Body' => $client->getObject(['Bucket' => 'foo', 'Key' => 'bar'])->getBody()->getContentAsResource(),
+        ])->resolve();
+
+        self::expectNotToPerformAssertions();
+    }
+
     private function getClient(): S3Client
     {
         return new S3Client([