Add strict comparison null !== instead of !

Author: jderusse

src/CodeGenerator/src/Generator/PaginationGenerator.php

@@ -207,7 +207,8 @@ private function generateOutputPaginationLoader(string $iterator, string $common
         if (!$moreResult) {
             $moreCondition = '';
             foreach ($outputToken as $property) {
-                $moreCondition .= $this->generateGetter('$page', $property, (bool) $common);
+                $moreCondition .= 'null !== '.$this->generateGetter('$page', $property, (bool) $common);
+                break;
             }
         } else {
             $moreCondition = $this->generateGetter('$page', $moreResult, (bool) $common);

src/CodeGenerator/src/Generator/ResponseParser/RestXmlParser.php

@@ -215,7 +215,7 @@ private function parseXmlResponseStructure(StructureShape $shape, string $input,
         return strtr('REQUIRED new CLASS_NAME([
             PROPERTIES
         ])', [
-            'REQUIRED' => $required ? '' : '!' . $input . ' ? null : ',
+            'REQUIRED' => $required ? '' : 'null === ' . $input . ' ? null : ',
             'CLASS_NAME' => $this->namespaceRegistry->getObject($shape)->getName(),
             'PROPERTIES' => implode("\n", $properties),
         ]);
@@ -321,7 +321,7 @@ private function parseXmlResponseList(ListShape $shape, string $input, bool $req
             'INPUT_PROPERTY' => $shape->isFlattened() ? '$xml' : ('$xml->' . ($shapeMember->getLocationName() ? $shapeMember->getLocationName() : 'member')),
         ]), $shape);
 
-        return strtr($required ? '$this->FUNCTION_NAME(INPUT)' : '!INPUT ? EMPTY : $this->FUNCTION_NAME(INPUT)', [
+        return strtr($required ? '$this->FUNCTION_NAME(INPUT)' : 'null === INPUT ? EMPTY : $this->FUNCTION_NAME(INPUT)', [
             'EMPTY' => !$inObject ? '[]' : 'null',
             'INPUT' => $input,
             'FUNCTION_NAME' => $functionName,
@@ -349,7 +349,7 @@ private function parseXmlResponseMap(MapShape $shape, string $input, bool $requi
             'MAP_ACCESSOR' => $this->parseXmlElement('$a', $shapeValue->getShape(), true, $inObject),
         ]), $shape);
 
-        return strtr($required ? '$this->FUNCTION_NAME(INPUT)' : '!INPUT ? EMPTY : $this->FUNCTION_NAME(INPUT)', [
+        return strtr($required ? '$this->FUNCTION_NAME(INPUT)' : 'null === INPUT ? EMPTY : $this->FUNCTION_NAME(INPUT)', [
             'EMPTY' => !$inObject ? '[]' : 'null',
             'INPUT' => $input,
             'FUNCTION_NAME' => $functionName,

src/Core/CHANGELOG.md

@@ -8,6 +8,7 @@
 
 ### Changed
 
+- use strict comparison `null !==` instead of `!`
 - Fix CS
 
 ## 1.22.1

src/Core/src/Signer/SignerV4.php

@@ -317,7 +317,7 @@ private function buildCanonicalQuery(Request $request): string
         $query = $request->getQuery();
 
         unset($query['X-Amz-Signature']);
-        if (!$query) {
+        if (empty($query)) {
             return '';
         }
 

src/Core/src/Sts/Result/AssumeRoleResponse.php

@@ -94,13 +94,13 @@ protected function populateResult(Response $response): void
         $data = new \SimpleXMLElement($response->getContent());
         $data = $data->AssumeRoleResult;
 
-        $this->credentials = !$data->Credentials ? null : new Credentials([
+        $this->credentials = null === $data->Credentials ? null : new Credentials([
             'AccessKeyId' => (string) $data->Credentials->AccessKeyId,
             'SecretAccessKey' => (string) $data->Credentials->SecretAccessKey,
             'SessionToken' => (string) $data->Credentials->SessionToken,
             'Expiration' => new \DateTimeImmutable((string) $data->Credentials->Expiration),
         ]);
-        $this->assumedRoleUser = !$data->AssumedRoleUser ? null : new AssumedRoleUser([
+        $this->assumedRoleUser = null === $data->AssumedRoleUser ? null : new AssumedRoleUser([
             'AssumedRoleId' => (string) $data->AssumedRoleUser->AssumedRoleId,
             'Arn' => (string) $data->AssumedRoleUser->Arn,
         ]);

src/Core/src/Sts/Result/AssumeRoleWithWebIdentityResponse.php

@@ -147,14 +147,14 @@ protected function populateResult(Response $response): void
         $data = new \SimpleXMLElement($response->getContent());
         $data = $data->AssumeRoleWithWebIdentityResult;
 
-        $this->credentials = !$data->Credentials ? null : new Credentials([
+        $this->credentials = null === $data->Credentials ? null : new Credentials([
             'AccessKeyId' => (string) $data->Credentials->AccessKeyId,
             'SecretAccessKey' => (string) $data->Credentials->SecretAccessKey,
             'SessionToken' => (string) $data->Credentials->SessionToken,
             'Expiration' => new \DateTimeImmutable((string) $data->Credentials->Expiration),
         ]);
         $this->subjectFromWebIdentityToken = ($v = $data->SubjectFromWebIdentityToken) ? (string) $v : null;
-        $this->assumedRoleUser = !$data->AssumedRoleUser ? null : new AssumedRoleUser([
+        $this->assumedRoleUser = null === $data->AssumedRoleUser ? null : new AssumedRoleUser([
             'AssumedRoleId' => (string) $data->AssumedRoleUser->AssumedRoleId,
             'Arn' => (string) $data->AssumedRoleUser->Arn,
         ]);

src/Service/AppSync/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## NOT RELEASED
 
+### Changed
+
+- use strict comparison `null !==` instead of `!`
+
 ## 3.0.0
 
 ### BC-BREAK

src/Service/AppSync/src/Result/ListApiKeysResponse.php

@@ -53,7 +53,7 @@ public function getApiKeys(bool $currentPageOnly = false): iterable
         $page = $this;
         while (true) {
             $page->initialize();
-            if ($page->nextToken) {
+            if (null !== $page->nextToken) {
                 $input->setNextToken($page->nextToken);
 
                 $this->registerPrefetch($nextPage = $client->listApiKeys($input));

src/Service/AppSync/src/Result/ListResolversResponse.php

@@ -75,7 +75,7 @@ public function getResolvers(bool $currentPageOnly = false): iterable
         $page = $this;
         while (true) {
             $page->initialize();
-            if ($page->nextToken) {
+            if (null !== $page->nextToken) {
                 $input->setNextToken($page->nextToken);
 
                 $this->registerPrefetch($nextPage = $client->listResolvers($input));

src/Service/Athena/CHANGELOG.md

@@ -6,6 +6,10 @@
 
 - AWS api-change: Removing FEDERATED from Create/List/Delete/GetDataCatalog API
 
+### Changed
+
+- use strict comparison `null !==` instead of `!`
+
 ## 2.3.0
 
 ### Added