Skip to content

fix minor bug in logic #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2025
Merged

fix minor bug in logic #1833

merged 2 commits into from
Jan 15, 2025
+10 −3

Conversation

@Nyholm
Copy link
Member

@Nyholm Nyholm commented Jan 15, 2025

I do believe this was missed in the review for #1831

@Nyholm Nyholm requested a review from jderusse January 15, 2025 10:29
@Nyholm
Copy link
Member Author

Nyholm commented Jan 15, 2025

Wait, there are more problems here.

I see we have getCredentialsFromSsoSession() and getCredentialsFromLegacySso() both are using async-aws/sso. But getCredentialsFromSsoSession() is also using async-aws/sso-oidc. Is that correct?

@jderusse
Copy link
Member

Wait, there are more problems here.

I see we have getCredentialsFromSsoSession() and getCredentialsFromLegacySso() both are using async-aws/sso. But getCredentialsFromSsoSession() is also using async-aws/sso-oidc. Is that correct?

yes, sso_session use both async-aws/sso and async-aws/sso-oidc could you amend your PR please?

@jderusse jderusse mentioned this pull request Jan 15, 2025
Merged
@jderusse jderusse merged commit 1e1e7bb into async-aws:master Jan 15, 2025
17 checks passed
@Nyholm
Copy link
Member Author

Nyholm commented Jan 15, 2025

Thank you for merging

@Nyholm Nyholm deleted the sso-bug branch January 15, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jderusse jderusse jderusse approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Nyholm @jderusse