Avoid overriding the exception message with the raw message (#1516)

Author: stof

src/Sts/Exception/ExpiredTokenException.php

@@ -3,22 +3,11 @@
 namespace AsyncAws\Core\Sts\Exception;
 
 use AsyncAws\Core\Exception\Http\ClientException;
-use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
  * The web identity token that was passed is expired or is not valid. Get a new identity token from the identity
  * provider and then retry the request.
  */
 final class ExpiredTokenException extends ClientException
 {
-    protected function populateResult(ResponseInterface $response): void
-    {
-        $data = new \SimpleXMLElement($response->getContent(false));
-        if (0 < $data->Error->count()) {
-            $data = $data->Error;
-        }
-        if (null !== $v = (($v = $data->message) ? (string) $v : null)) {
-            $this->message = $v;
-        }
-    }
 }

src/Sts/Exception/IDPCommunicationErrorException.php

@@ -3,7 +3,6 @@
 namespace AsyncAws\Core\Sts\Exception;
 
 use AsyncAws\Core\Exception\Http\ClientException;
-use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
  * The request could not be fulfilled because the identity provider (IDP) that was asked to verify the incoming identity
@@ -13,14 +12,4 @@
  */
 final class IDPCommunicationErrorException extends ClientException
 {
-    protected function populateResult(ResponseInterface $response): void
-    {
-        $data = new \SimpleXMLElement($response->getContent(false));
-        if (0 < $data->Error->count()) {
-            $data = $data->Error;
-        }
-        if (null !== $v = (($v = $data->message) ? (string) $v : null)) {
-            $this->message = $v;
-        }
-    }
 }

src/Sts/Exception/IDPRejectedClaimException.php

@@ -3,7 +3,6 @@
 namespace AsyncAws\Core\Sts\Exception;
 
 use AsyncAws\Core\Exception\Http\ClientException;
-use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
  * The identity provider (IdP) reported that authentication failed. This might be because the claim is invalid.
@@ -13,14 +12,4 @@
  */
 final class IDPRejectedClaimException extends ClientException
 {
-    protected function populateResult(ResponseInterface $response): void
-    {
-        $data = new \SimpleXMLElement($response->getContent(false));
-        if (0 < $data->Error->count()) {
-            $data = $data->Error;
-        }
-        if (null !== $v = (($v = $data->message) ? (string) $v : null)) {
-            $this->message = $v;
-        }
-    }
 }

src/Sts/Exception/InvalidIdentityTokenException.php

@@ -3,22 +3,11 @@
 namespace AsyncAws\Core\Sts\Exception;
 
 use AsyncAws\Core\Exception\Http\ClientException;
-use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
  * The web identity token that was passed could not be validated by Amazon Web Services. Get a new identity token from
  * the identity provider and then retry the request.
  */
 final class InvalidIdentityTokenException extends ClientException
 {
-    protected function populateResult(ResponseInterface $response): void
-    {
-        $data = new \SimpleXMLElement($response->getContent(false));
-        if (0 < $data->Error->count()) {
-            $data = $data->Error;
-        }
-        if (null !== $v = (($v = $data->message) ? (string) $v : null)) {
-            $this->message = $v;
-        }
-    }
 }

src/Sts/Exception/MalformedPolicyDocumentException.php

@@ -3,21 +3,10 @@
 namespace AsyncAws\Core\Sts\Exception;
 
 use AsyncAws\Core\Exception\Http\ClientException;
-use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
  * The request was rejected because the policy document was malformed. The error message describes the specific error.
  */
 final class MalformedPolicyDocumentException extends ClientException
 {
-    protected function populateResult(ResponseInterface $response): void
-    {
-        $data = new \SimpleXMLElement($response->getContent(false));
-        if (0 < $data->Error->count()) {
-            $data = $data->Error;
-        }
-        if (null !== $v = (($v = $data->message) ? (string) $v : null)) {
-            $this->message = $v;
-        }
-    }
 }

src/Sts/Exception/PackedPolicyTooLargeException.php

@@ -3,7 +3,6 @@
 namespace AsyncAws\Core\Sts\Exception;
 
 use AsyncAws\Core\Exception\Http\ClientException;
-use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
  * The request was rejected because the total packed size of the session policies and session tags combined was too
@@ -20,14 +19,4 @@
  */
 final class PackedPolicyTooLargeException extends ClientException
 {
-    protected function populateResult(ResponseInterface $response): void
-    {
-        $data = new \SimpleXMLElement($response->getContent(false));
-        if (0 < $data->Error->count()) {
-            $data = $data->Error;
-        }
-        if (null !== $v = (($v = $data->message) ? (string) $v : null)) {
-            $this->message = $v;
-        }
-    }
 }

src/Sts/Exception/RegionDisabledException.php

@@ -3,7 +3,6 @@
 namespace AsyncAws\Core\Sts\Exception;
 
 use AsyncAws\Core\Exception\Http\ClientException;
-use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
  * STS is not activated in the requested region for the account that is being asked to generate credentials. The account
@@ -14,14 +13,4 @@
  */
 final class RegionDisabledException extends ClientException
 {
-    protected function populateResult(ResponseInterface $response): void
-    {
-        $data = new \SimpleXMLElement($response->getContent(false));
-        if (0 < $data->Error->count()) {
-            $data = $data->Error;
-        }
-        if (null !== $v = (($v = $data->message) ? (string) $v : null)) {
-            $this->message = $v;
-        }
-    }
 }