Skip to content

Commit 18cb1f6

Browse files
authored
Simplify Crendential generation (#190)
1 parent 792bfb7 commit 18cb1f6

File tree

2 files changed

+25
-12
lines changed

2 files changed

+25
-12
lines changed

AbstractApi.php

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -67,18 +67,11 @@ public function __construct($configuration = [], ?CredentialProvider $credential
6767
$this->httpClient = $httpClient ?? HttpClient::create();
6868
$this->logger = $logger ?? new NullLogger();
6969
$this->configuration = $configuration;
70-
if ($configuration->isDefault(Configuration::OPTION_ENDPOINT)) {
71-
$this->credentialProvider = $credentialProvider ?? new CacheProvider(new ChainProvider([
72-
new ConfigurationProvider(),
73-
new IniFileProvider($this->logger),
74-
new InstanceProvider($this->httpClient, $this->logger),
75-
]));
76-
} else {
77-
$this->credentialProvider = $credentialProvider ?? new CacheProvider(new ChainProvider([
78-
new ConfigurationProvider(),
79-
new IniFileProvider($this->logger),
80-
]));
81-
}
70+
$this->credentialProvider = $credentialProvider ?? new CacheProvider(new ChainProvider([
71+
new ConfigurationProvider(),
72+
new IniFileProvider($this->logger),
73+
new InstanceProvider($this->httpClient, $this->logger),
74+
]));
8275
}
8376

8477
/**

Credentials/NullProvider.php

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
<?php
2+
3+
declare(strict_types=1);
4+
5+
namespace AsyncAws\Core\Credentials;
6+
7+
use AsyncAws\Core\Configuration;
8+
9+
/**
10+
* Returns null.
11+
*
12+
* @author Jérémy Derussé <[email protected]>
13+
*/
14+
class NullProvider implements CredentialProvider
15+
{
16+
public function getCredentials(Configuration $configuration): ?Credentials
17+
{
18+
return null;
19+
}
20+
}

0 commit comments

Comments
 (0)