Use hash_update_stream to compute hash on resource (#360)

jderusse · web-flow · commit 44f2717349f2 · 2020-03-24T09:55:33.000+01:00
diff --git a/src/Stream/ResourceStream.php b/src/Stream/ResourceStream.php
@@ -84,11 +84,9 @@ public function hash(string $algo = 'sha256', bool $raw = false): string
         }
 
         $ctx = hash_init($algo);
-        while (!feof($this->content)) {
-            hash_update($ctx, fread($this->content, 1048576));
-        }
-
+        hash_update_stream($ctx, $this->content);
         $out = hash_final($ctx, $raw);
+
         if (-1 === fseek($this->content, $pos)) {
             throw new InvalidArgument('Unable to seek the content.');
         }

Original file line number	Diff line number	Diff line change
`@@ -84,11 +84,9 @@ public function hash(string $algo = 'sha256', bool $raw = false): string`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`$ctx = hash_init($algo);`
`87`		`- while (!feof($this->content)) {`
`88`		`- hash_update($ctx, fread($this->content, 1048576));`
`89`		`- }`
`90`		`-`
	`87`	`+ hash_update_stream($ctx, $this->content);`
`91`	`88`	`$out = hash_final($ctx, $raw);`
	`89`	`+`
`92`	`90`	`if (-1 === fseek($this->content, $pos)) {`
`93`	`91`	`throw new InvalidArgument('Unable to seek the content.');`
`94`	`92`	`}`