[DynamoDB] Add waiter for table not exists after delete (#338)

* Add waiter for table delete

* WIP rework waiter generator & exception condition

* Response::resolve() always throw exceptions, that can be caught

* Fix error waiter for sqs

* Fallback to full __type error code, like official sdk

* Waiter::resolve() ignores http exceptions

Author: GromNaN

src/Exception/Http/HttpExceptionTrait.php

@@ -70,6 +70,12 @@ public function __construct(ResponseInterface $response)
         // The MIME type isn't explicitly checked because some formats inherit from others
         // Ex: JSON:API follows RFC 7807 semantics, Hydra can be used in any JSON-LD-compatible format
         if ($isJson && $body = json_decode($response->getContent(false), true)) {
+            if (isset($body['__type'])) {
+                $parts = explode('#', $body['__type'], 2);
+                $this->awsCode = $parts[1] ?? $parts[0];
+                $message .= "\n\n" . $body['__type'] . "\n\n";
+            }
+
             if (isset($body['hydra:title']) || isset($body['hydra:description'])) {
                 // see http://www.hydra-cg.com/spec/latest/core/#description-of-http-status-codes-and-errors
                 $separator = isset($body['hydra:title'], $body['hydra:description']) ? "\n\n" : '';

src/Response.php

@@ -51,14 +51,13 @@ public function __destruct()
      * Make sure the actual request is executed.
      *
      * @param float|null $timeout Duration in seconds before aborting. When null wait until the end of execution.
-     * @param bool       $throw   Whether an exception should be thrown on 3/4/5xx status codes
      *
      * @return bool whether the request is executed or not
      *
      * @throws NetworkException
      * @throws HttpException
      */
-    final public function resolve(?float $timeout = null, bool $throw = true): bool
+    final public function resolve(?float $timeout = null): bool
     {
         if (null !== $this->resolveResult) {
             if ($this->resolveResult instanceof \Exception) {
@@ -87,18 +86,16 @@ final public function resolve(?float $timeout = null, bool $throw = true): bool
             throw $this->resolveResult = new NetworkException('Could not contact remote server.', 0, $e);
         }
 
-        if ($throw) {
-            if (500 <= $statusCode) {
-                throw $this->resolveResult = new ServerException($this->response);
-            }
+        if (500 <= $statusCode) {
+            throw $this->resolveResult = new ServerException($this->response);
+        }
 
-            if (400 <= $statusCode) {
-                throw $this->resolveResult = new ClientException($this->response);
-            }
+        if (400 <= $statusCode) {
+            throw $this->resolveResult = new ClientException($this->response);
+        }
 
-            if (300 <= $statusCode) {
-                throw $this->resolveResult = new RedirectionException($this->response);
-            }
+        if (300 <= $statusCode) {
+            throw $this->resolveResult = new RedirectionException($this->response);
         }
 
         return $this->resolveResult = true;

src/Waiter.php

@@ -64,9 +64,7 @@ public function __construct(Response $response, AbstractApi $awsClient, $request
 
     public function __destruct()
     {
-        if (null === $this->resolveResult) {
-            $this->resolve();
-        }
+        $this->resolve();
     }
 
     final public function isSuccess(): bool
@@ -94,8 +92,12 @@ final public function getState(): string
             $this->stealResponse($this->refreshState());
         }
 
-        $exception = null;
-        $this->resolve();
+        try {
+            $this->response->resolve();
+            $exception = null;
+        } catch (HttpException $exception) {
+            // use $exception later
+        }
 
         $state = $this->extractState($this->response, $exception);
         $this->needRefresh = true;
@@ -120,13 +122,15 @@ final public function getState(): string
      *
      * @param float|null $timeout Duration in seconds before aborting. When null wait until the end of execution.
      *
-     * @return bool whether the request is executed or not
-     *
      * @throws NetworkException
      */
     final public function resolve(?float $timeout = null): bool
     {
-        return $this->response->resolve($timeout, false);
+        try {
+            return $this->response->resolve($timeout);
+        } catch (HttpException $exception) {
+            return true;
+        }
     }
 
     /**