Add TestCase that simplify assertion on http form (#209)

Author: jderusse

Test/TestCase.php

@@ -0,0 +1,30 @@
+<?php
+
+namespace AsyncAws\Core\Test;
+
+use PHPUnit\Framework\TestCase as PHPUnitTestCase;
+
+class TestCase extends PHPUnitTestCase
+{
+    /**
+     * Asserts that two Body documents are equal.
+     */
+    public static function assertHttpFormEqualsHttpForm(string $expected, string $actual, string $message = '')
+    {
+        $expectedArray = \preg_split('/[\n&\s]+/', trim($expected));
+        $actualArray = \preg_split('/[\n&\s]+/', trim($actual));
+
+        self::assertEqualsCanonicalizing($expectedArray, $actualArray, $message);
+    }
+}
+
+// Because AsyncAws use symfony/phpunit-bridge and don't requires phpunit/phpunit, this class may not exits but is required by the generator and static analyzer tools
+if (!\class_exists(PHPUnitTestCase::class)) {
+    class DummyTestCase
+    {
+        public static function assertEqualsCanonicalizing($expected, $actual, string $message = ''): void
+        {
+        }
+    }
+    \class_alias(DummyTestCase::class, PHPUnitTestCase::class);
+}

Tests/Unit/Input/AssumeRoleRequestTest.php

@@ -5,7 +5,7 @@
 use AsyncAws\Core\Sts\Input\AssumeRoleRequest;
 use AsyncAws\Core\Sts\Input\PolicyDescriptorType;
 use AsyncAws\Core\Sts\Input\Tag;
-use PHPUnit\Framework\TestCase;
+use AsyncAws\Core\Test\TestCase;
 
 class AssumeRoleRequestTest extends TestCase
 {
@@ -35,7 +35,7 @@ public function testRequestBody(): void
         ]);
 
         /** @see https://docs.aws.amazon.com/STS/latest/APIReference/API_AssumeRole.html */
-        $expected = trim('
+        $expected = '
 Action=AssumeRole
 &Version=2011-06-15
 &RoleArn=arn%3Aaws%3A%3Aiam%3A%3A123456789012%3Arole%2Fdemo
@@ -53,8 +53,8 @@ public function testRequestBody(): void
 &TransitiveTagKeys.member.1=Project
 &TransitiveTagKeys.member.2=Cost-Center
 &ExternalId=123ABC
-        ');
+        ';
 
-        self::assertEquals($expected, \str_replace('&', "\n&", $input->requestBody()));
+        self::assertHttpFormEqualsHttpForm($expected, $input->requestBody());
     }
 }

Tests/Unit/Input/GetCallerIdentityRequestTest.php

@@ -3,7 +3,7 @@
 namespace AsyncAws\Core\Tests\Unit\Input;
 
 use AsyncAws\Core\Sts\Input\GetCallerIdentityRequest;
-use PHPUnit\Framework\TestCase;
+use AsyncAws\Core\Test\TestCase;
 
 class GetCallerIdentityRequestTest extends TestCase
 {
@@ -12,11 +12,11 @@ public function testRequestBody(): void
         $input = new GetCallerIdentityRequest();
 
         /** @see https://docs.aws.amazon.com/STS/latest/APIReference/API_GetCallerIdentity.html */
-        $expected = trim('
+        $expected = '
 Action=GetCallerIdentity
 &Version=2011-06-15
-        ');
+        ';
 
-        self::assertEquals($expected, \str_replace('&', "\n&", $input->requestBody()));
+        self::assertHttpFormEqualsHttpForm($expected, $input->requestBody());
     }
 }