Guess content type (#347)

* Guess content type

* Fixed tests

* Fixed typo

* Fixed test

* Updated comment

* update comment

* Updated phpunit coverage filter

Author: Nyholm

src/Exception/Http/HttpExceptionTrait.php

@@ -43,33 +43,11 @@ public function __construct(ResponseInterface $response)
         $this->response = $response;
         $code = $response->getInfo('http_code');
         $url = $response->getInfo('url');
+        $content = $response->getContent(false);
         $message = sprintf('HTTP %d returned for "%s".', $code, $url);
 
-        $httpCodeFound = false;
-        $isJson = false;
-        foreach (array_reverse($response->getInfo('response_headers')) as $h) {
-            if (0 === strpos($h, 'HTTP/')) {
-                if ($httpCodeFound) {
-                    break;
-                }
-
-                $message = sprintf('%s returned for "%s".', $h, $url);
-                $httpCodeFound = true;
-            }
-
-            if (0 === stripos($h, 'content-type:')) {
-                if (preg_match('/\bjson\b/i', $h)) {
-                    $isJson = true;
-                }
-
-                if ($httpCodeFound) {
-                    break;
-                }
-            }
-        }
-
-        $content = $response->getContent(false);
-        if ($isJson && $body = json_decode($content, true)) {
+        // Try json_decode it first, fallback to XML
+        if ($body = json_decode($content, true)) {
             $this->parseJson($body);
         } else {
             try {

src/Result.php

@@ -8,8 +8,7 @@
 use AsyncAws\Core\Exception\Http\NetworkException;
 
 /**
- * The result promise is always returned from every API call. Remember to call `resolve()` to
- * make sure the request is actually sent.
+ * Base class for all return values from a Api Client methods. Example: `FooClient::bar(): Result`.
  */
 class Result
 {