Avoid overriding the exception message with the raw message (#1516)

Author: stof

src/Exception/ConditionalCheckFailedException.php

@@ -30,9 +30,6 @@ protected function populateResult(ResponseInterface $response): void
     {
         $data = $response->toArray(false);
 
-        if (null !== $v = (isset($data['message']) ? (string) $data['message'] : null)) {
-            $this->message = $v;
-        }
         $this->item = empty($data['Item']) ? [] : $this->populateResultAttributeMap($data['Item']);
     }
 

src/Exception/DuplicateItemException.php

@@ -3,20 +3,11 @@
 namespace AsyncAws\DynamoDb\Exception;
 
 use AsyncAws\Core\Exception\Http\ClientException;
-use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
  * There was an attempt to insert an item with the same primary key as an item that already exists in the DynamoDB
  * table.
  */
 final class DuplicateItemException extends ClientException
 {
-    protected function populateResult(ResponseInterface $response): void
-    {
-        $data = $response->toArray(false);
-
-        if (null !== $v = (isset($data['message']) ? (string) $data['message'] : null)) {
-            $this->message = $v;
-        }
-    }
 }

src/Exception/IdempotentParameterMismatchException.php

@@ -3,20 +3,11 @@
 namespace AsyncAws\DynamoDb\Exception;
 
 use AsyncAws\Core\Exception\Http\ClientException;
-use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
  * DynamoDB rejected the request because you retried a request with a different payload but with an idempotent token
  * that was already used.
  */
 final class IdempotentParameterMismatchException extends ClientException
 {
-    protected function populateResult(ResponseInterface $response): void
-    {
-        $data = $response->toArray(false);
-
-        if (null !== $v = (isset($data['message']) ? (string) $data['message'] : null)) {
-            $this->message = $v;
-        }
-    }
 }

src/Exception/InternalServerErrorException.php

@@ -3,19 +3,10 @@
 namespace AsyncAws\DynamoDb\Exception;
 
 use AsyncAws\Core\Exception\Http\ClientException;
-use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
  * An error occurred on the server side.
  */
 final class InternalServerErrorException extends ClientException
 {
-    protected function populateResult(ResponseInterface $response): void
-    {
-        $data = $response->toArray(false);
-
-        if (null !== $v = (isset($data['message']) ? (string) $data['message'] : null)) {
-            $this->message = $v;
-        }
-    }
 }

src/Exception/ItemCollectionSizeLimitExceededException.php

@@ -3,20 +3,11 @@
 namespace AsyncAws\DynamoDb\Exception;
 
 use AsyncAws\Core\Exception\Http\ClientException;
-use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
  * An item collection is too large. This exception is only returned for tables that have one or more local secondary
  * indexes.
  */
 final class ItemCollectionSizeLimitExceededException extends ClientException
 {
-    protected function populateResult(ResponseInterface $response): void
-    {
-        $data = $response->toArray(false);
-
-        if (null !== $v = (isset($data['message']) ? (string) $data['message'] : null)) {
-            $this->message = $v;
-        }
-    }
 }

src/Exception/LimitExceededException.php

@@ -3,7 +3,6 @@
 namespace AsyncAws\DynamoDb\Exception;
 
 use AsyncAws\Core\Exception\Http\ClientException;
-use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
  * There is no limit to the number of daily on-demand backups that can be taken.
@@ -27,12 +26,4 @@
  */
 final class LimitExceededException extends ClientException
 {
-    protected function populateResult(ResponseInterface $response): void
-    {
-        $data = $response->toArray(false);
-
-        if (null !== $v = (isset($data['message']) ? (string) $data['message'] : null)) {
-            $this->message = $v;
-        }
-    }
 }

src/Exception/ProvisionedThroughputExceededException.php

@@ -3,7 +3,6 @@
 namespace AsyncAws\DynamoDb\Exception;
 
 use AsyncAws\Core\Exception\Http\ClientException;
-use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
  * Your request rate is too high. The Amazon Web Services SDKs for DynamoDB automatically retry requests that receive
@@ -15,12 +14,4 @@
  */
 final class ProvisionedThroughputExceededException extends ClientException
 {
-    protected function populateResult(ResponseInterface $response): void
-    {
-        $data = $response->toArray(false);
-
-        if (null !== $v = (isset($data['message']) ? (string) $data['message'] : null)) {
-            $this->message = $v;
-        }
-    }
 }

src/Exception/RequestLimitExceededException.php

@@ -3,7 +3,6 @@
 namespace AsyncAws\DynamoDb\Exception;
 
 use AsyncAws\Core\Exception\Http\ClientException;
-use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
  * Throughput exceeds the current throughput quota for your account. Please contact Amazon Web Services Support [^1] to
@@ -13,12 +12,4 @@
  */
 final class RequestLimitExceededException extends ClientException
 {
-    protected function populateResult(ResponseInterface $response): void
-    {
-        $data = $response->toArray(false);
-
-        if (null !== $v = (isset($data['message']) ? (string) $data['message'] : null)) {
-            $this->message = $v;
-        }
-    }
 }

src/Exception/ResourceInUseException.php

@@ -3,20 +3,11 @@
 namespace AsyncAws\DynamoDb\Exception;
 
 use AsyncAws\Core\Exception\Http\ClientException;
-use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
  * The operation conflicts with the resource's availability. For example, you attempted to recreate an existing table,
  * or tried to delete a table currently in the `CREATING` state.
  */
 final class ResourceInUseException extends ClientException
 {
-    protected function populateResult(ResponseInterface $response): void
-    {
-        $data = $response->toArray(false);
-
-        if (null !== $v = (isset($data['message']) ? (string) $data['message'] : null)) {
-            $this->message = $v;
-        }
-    }
 }

src/Exception/ResourceNotFoundException.php

@@ -3,20 +3,11 @@
 namespace AsyncAws\DynamoDb\Exception;
 
 use AsyncAws\Core\Exception\Http\ClientException;
-use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
  * The operation tried to access a nonexistent table or index. The resource might not be specified correctly, or its
  * status might not be `ACTIVE`.
  */
 final class ResourceNotFoundException extends ClientException
 {
-    protected function populateResult(ResponseInterface $response): void
-    {
-        $data = $response->toArray(false);
-
-        if (null !== $v = (isset($data['message']) ? (string) $data['message'] : null)) {
-            $this->message = $v;
-        }
-    }
 }