Skip to content

Commit 8f79484

Browse files
committed
book: retire noHeader prop
1 parent 12f359d commit 8f79484

File tree

10 files changed

+20
-20
lines changed

10 files changed

+20
-20
lines changed

book/4-end/lib/withAuth.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,4 +65,4 @@ export default (Page, { loginRequired = true, logoutRequired = false } = {}) =>
6565

6666
return <Page {...this.props} />;
6767
}
68-
};
68+
};

book/7-end/lib/withAuth.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@ let globalUser = null;
66

77
export default (
88
Page,
9-
{ loginRequired = true, logoutRequired = false, adminRequired = false, noHeader = false } = {},
10-
) => class BaseComponent extends React.Component {
9+
{ loginRequired = true, logoutRequired = false, adminRequired = false } = {},
10+
) =>
11+
class BaseComponent extends React.Component {
1112
static propTypes = {
1213
user: PropTypes.shape({
1314
id: PropTypes.string,
@@ -49,7 +50,7 @@ export default (
4950
user._id = user._id.toString();
5051
}
5152

52-
const props = { user, isFromServer, noHeader };
53+
const props = { user, isFromServer };
5354

5455
if (Page.getInitialProps) {
5556
Object.assign(props, (await Page.getInitialProps(ctx)) || {});

book/7-end/pages/_app.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ class MyApp extends App {
3737
const { Component, pageProps } = this.props;
3838

3939
// console.log(pageProps);
40-
// console.log(pageProps.noHeader);
4140

4241
return (
4342
<Container>
@@ -46,7 +45,7 @@ class MyApp extends App {
4645
<ThemeProvider theme={theme}>
4746
{/* CssBaseline kickstart an elegant, consistent, and simple baseline to build upon. */}
4847
<CssBaseline />
49-
{pageProps.noHeader ? null : <Header {...pageProps} />}
48+
{pageProps.chapter ? null : <Header {...pageProps} />}
5049
<Component {...pageProps} />
5150
<Notifier />
5251
</ThemeProvider>

book/7-end/pages/public/read-chapter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,4 +328,4 @@ class ReadChapter extends React.Component {
328328
}
329329
}
330330

331-
export default withAuth(ReadChapter, { loginRequired: false, noHeader: true });
331+
export default withAuth(ReadChapter, { loginRequired: false });

book/8-begin/lib/withAuth.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ let globalUser = null;
66

77
export default (
88
Page,
9-
{ loginRequired = true, logoutRequired = false, adminRequired = false, noHeader = false } = {},
9+
{ loginRequired = true, logoutRequired = false, adminRequired = false } = {},
1010
) =>
1111
class BaseComponent extends React.Component {
1212
static propTypes = {
@@ -50,7 +50,7 @@ export default (
5050
user._id = user._id.toString();
5151
}
5252

53-
const props = { user, isFromServer, noHeader };
53+
const props = { user, isFromServer };
5454

5555
if (Page.getInitialProps) {
5656
Object.assign(props, (await Page.getInitialProps(ctx)) || {});

book/8-begin/pages/_app.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ class MyApp extends App {
3737
const { Component, pageProps } = this.props;
3838

3939
// console.log(pageProps);
40-
// console.log(pageProps.noHeader);
4140

4241
return (
4342
<Container>
@@ -46,7 +45,7 @@ class MyApp extends App {
4645
<ThemeProvider theme={theme}>
4746
{/* CssBaseline kickstart an elegant, consistent, and simple baseline to build upon. */}
4847
<CssBaseline />
49-
{pageProps.noHeader ? null : <Header {...pageProps} />}
48+
{pageProps.chapter ? null : <Header {...pageProps} />}
5049
<Component {...pageProps} />
5150
<Notifier />
5251
</ThemeProvider>

book/8-begin/pages/public/read-chapter.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class ReadChapter extends React.Component {
2121
static propTypes = {
2222
chapter: PropTypes.shape({
2323
_id: PropTypes.string.isRequired,
24-
isPurchased: PropTypes.bool.isRequired,
24+
isPurchased: PropTypes.bool,
2525
isFree: PropTypes.bool.isRequired,
2626
htmlContent: PropTypes.string,
2727
htmlExcerpt: PropTypes.string,
@@ -330,4 +330,4 @@ class ReadChapter extends React.Component {
330330
}
331331
}
332332

333-
export default withAuth(ReadChapter, { loginRequired: false, noHeader: true });
333+
export default withAuth(ReadChapter, { loginRequired: false });

book/8-end/lib/withAuth.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@ let globalUser = null;
66

77
export default (
88
Page,
9-
{ loginRequired = true, logoutRequired = false, adminRequired = false, noHeader = false } = {},
10-
) => class BaseComponent extends React.Component {
9+
{ loginRequired = true, logoutRequired = false, adminRequired = false } = {},
10+
) =>
11+
class BaseComponent extends React.Component {
1112
static propTypes = {
1213
user: PropTypes.shape({
1314
id: PropTypes.string,
@@ -49,7 +50,7 @@ export default (
4950
user._id = user._id.toString();
5051
}
5152

52-
const props = { user, isFromServer, noHeader };
53+
const props = { user, isFromServer };
5354

5455
if (Page.getInitialProps) {
5556
Object.assign(props, (await Page.getInitialProps(ctx)) || {});

book/8-end/pages/_app.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ class MyApp extends App {
3737
const { Component, pageProps } = this.props;
3838

3939
// console.log(pageProps);
40-
// console.log(pageProps.noHeader);
4140

4241
return (
4342
<Container>
@@ -46,7 +45,7 @@ class MyApp extends App {
4645
<ThemeProvider theme={theme}>
4746
{/* CssBaseline kickstart an elegant, consistent, and simple baseline to build upon. */}
4847
<CssBaseline />
49-
{pageProps.noHeader ? null : <Header {...pageProps} />}
48+
{pageProps.chapter ? null : <Header {...pageProps} />}
5049
<Component {...pageProps} />
5150
<Notifier />
5251
</ThemeProvider>

book/8-end/pages/public/read-chapter.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class ReadChapter extends React.Component {
2323
static propTypes = {
2424
chapter: PropTypes.shape({
2525
_id: PropTypes.string.isRequired,
26-
isPurchased: PropTypes.bool.isRequired,
26+
isPurchased: PropTypes.bool,
2727
isFree: PropTypes.bool.isRequired,
2828
htmlContent: PropTypes.string,
2929
htmlExcerpt: PropTypes.string,
@@ -35,11 +35,13 @@ class ReadChapter extends React.Component {
3535
asPath: PropTypes.string.isRequired,
3636
}).isRequired,
3737
showStripeModal: PropTypes.bool.isRequired,
38+
noHeader: PropTypes.bool,
3839
};
3940

4041
static defaultProps = {
4142
chapter: null,
4243
user: null,
44+
noHeader: true,
4345
};
4446

4547
constructor(props, ...args) {
@@ -353,5 +355,4 @@ class ReadChapter extends React.Component {
353355

354356
export default withAuth(withRouter(ReadChapter), {
355357
loginRequired: false,
356-
noHeader: true,
357358
});

0 commit comments

Comments
 (0)