Merge pull request #28 from arielb1/less-flaky

increase the number of threads in slow example to reduce flakiness

Author: arielb1

.github/workflows/build.yml

@@ -83,7 +83,7 @@ jobs:
   test:
     name: Integration Test
     runs-on: ubuntu-latest
-    needs: [build, build-for-testing, build-decoder, build-async-profiler]
+    needs: [build-for-testing, build-decoder, build-async-profiler]
     steps:
       - uses: actions/checkout@v4
       - name: Download pollcatch-decoder

examples/simple/main.rs

@@ -51,28 +51,33 @@ struct Args {
     #[arg(long, default_value = "30s")]
     #[clap(value_parser = humantime::parse_duration)]
     reporting_interval: Duration,
+    #[arg(long)]
+    worker_threads: Option<usize>,
 }
 
 #[allow(unexpected_cfgs)]
 pub fn main() -> anyhow::Result<()> {
+    let args = Args::parse();
+
     let mut rt: tokio::runtime::Builder = tokio::runtime::Builder::new_multi_thread();
     rt.enable_all();
+    if let Some(worker_threads) = args.worker_threads {
+        rt.worker_threads(worker_threads);
+    }
 
     #[cfg(tokio_unstable)]
     {
         rt.on_before_task_poll(|_| async_profiler_agent::pollcatch::before_poll_hook())
             .on_after_task_poll(|_| async_profiler_agent::pollcatch::after_poll_hook());
     }
     let rt = rt.build().unwrap();
-    rt.block_on(main_internal())
+    rt.block_on(main_internal(args))
 }
 
-async fn main_internal() -> Result<(), anyhow::Error> {
+async fn main_internal(args: Args) -> Result<(), anyhow::Error> {
     set_up_tracing();
     tracing::info!("main started");
 
-    let args = Args::parse();
-
     let profiler = ProfilerBuilder::default();
 
     let profiler = match (

tests/integration.sh

@@ -9,7 +9,8 @@ set -exuo pipefail
 
 mkdir -p profiles
 rm -f profiles/*.jfr
-./simple --local profiles --duration 60s --reporting-interval 15s
+# Pass --worker-threads 16 to make the test much less flaky since there is always some worker thread running
+./simple --local profiles --duration 60s --reporting-interval 15s --worker-threads 16
 for profile in profiles/*.jfr; do
     short_sleeps_100=$(./pollcatch-decoder longpolls --stack-depth=10 "$profile" 100us | ( grep -c short_sleep_2 || true ))
     short_sleeps_1000=$(./pollcatch-decoder longpolls --stack-depth=10 "$profile" 1000us | ( grep -c short_sleep_2 || true ))