fix: correct resolver configuration merge in ValidationService (#1891)

* fix: correct resolver configuration merge in ValidationService

Fixes #1839

* chore: add changeset for PR #1891

* test: add regression test for resolver config merge bug

* chore: add changeset for PR #1891

* test: add integration test for external file reference resolution

* chore: add changeset for PR #1891

* chore: delete changeset

Deleting changeset as release workflow is not working right now.

---------

Co-authored-by: asyncapi-bot <info@asyncapi.io>
Co-authored-by: Ashish Padhy <ashishpadhy1729@gmail.com>

Author: 3 people

src/domains/services/validation.service.ts

@@ -184,14 +184,15 @@ export class ValidationService extends BaseService {
     const customParserOptions = {
       ...parserOptions,
       __unstable: {
+        ...parserOptions.__unstable,
         resolver: {
+          ...parserOptions.__unstable?.resolver,
           cache: false,
           resolvers: [
             createHttpWithAuthResolver(),
             ...(parserOptions.__unstable?.resolver?.resolvers || [])
           ],
         },
-        ...parserOptions.__unstable?.resolver,
       },
     };
 

test/fixtures/external-refs/main.yaml

@@ -0,0 +1,11 @@
+asyncapi: "2.6.0"
+info:
+  title: Service with External Refs
+  version: 1.0.0
+  description: AsyncAPI document with external file references in same directory
+channels:
+  user/created:
+    subscribe:
+      message:
+        payload:
+          $ref: "./schemas.yaml#/components/schemas/UserSchema"

test/fixtures/external-refs/schemas.yaml

@@ -0,0 +1,20 @@
+components:
+  schemas:
+    UserSchema:
+      type: object
+      properties:
+        id:
+          type: string
+          format: uuid
+          description: User ID
+        name:
+          type: string
+          description: User name
+        email:
+          type: string
+          format: email
+          description: User email
+      required:
+        - id
+        - name
+        - email

test/integration/validate.test.ts

@@ -84,6 +84,16 @@ describe('validate', () => {
         expect(ctx.stderr).to.equal('');
         done();
       });
+
+    test
+      .stderr()
+      .stdout()
+      .command(['validate', './test/fixtures/external-refs/main.yaml'])
+      .it('should resolve external file references in same directory', (ctx, done) => {
+        expect(ctx.stdout).to.include('File ./test/fixtures/external-refs/main.yaml is valid');
+        expect(ctx.stderr).to.equal('');
+        done();
+      });
   });
 
   describe('with context names', () => {