-
-
Notifications
You must be signed in to change notification settings - Fork 307
fix: windows release by aligning Node version with engine requirements #1983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR aims to fix Windows release failures by aligning the CI Node.js version with the engine requirements specified in package.json (Node ≥24). The change updates the Windows asset upload workflow to use .nvmrc for determining the Node version instead of the hardcoded Node 20.
Changes:
- Updates the Windows build step in the release asset upload workflow to read Node version from
.nvmrcfile instead of using a hardcoded version
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
hey @Shurtu-gal , |
Shurtu-gal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at other workflows as well in case we are missing node version fix.
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 20 | ||
| node-version-file: '.nvmrc' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have nvmrc file.
You can use this instead.
cli/.github/workflows/release-with-changesets.yml
Lines 95 to 105 in 870eb6b
| - if: steps.packagejson.outputs.exists == 'true' | |
| name: Check package-lock version | |
| uses: asyncapi/.github/.github/actions/get-node-version-from-package-lock@master | |
| id: lockversion | |
| with: | |
| node-version: ${{ vars.NODE_VERSION }} | |
| - if: steps.packagejson.outputs.exists == 'true' | |
| name: Setup Node.js | |
| uses: actions/setup-node@v6 | |
| with: | |
| node-version: "${{ steps.lockversion.outputs.version }}" |
e64b696 to
e535316
Compare
e535316 to
5d34899
Compare
|
|
Sorry about that @Shurtu-gal — I missed cross-checking this earlier. I have now updated the workflow to remove the .nvmrc usage and aligned the Node version setup with the pattern used in release-with-changesets.yml. All checks are passing, and I also verified the fix locally. Could you please take another look when you have time? Thanks! |



Description
.exeartifacts.Related issue(s)
Resolves #1982