Skip to content

Conversation

@Varadraj75
Copy link
Contributor

Description

  • Fixes Windows release failures by aligning CI Node.js version with current engine requirements (Node ≥ 24, npm ≥ 11).
  • Updates the release asset upload workflow to use the correct Node version, preventing missing Windows .exe artifacts.
  • Ensures CI behavior is consistent with the release workflow and local development setup.

Related issue(s)

Resolves #1982

Copilot AI review requested due to automatic review settings January 23, 2026 18:08
@github-project-automation github-project-automation bot moved this to To Triage in CLI - Kanban Jan 23, 2026
@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2026

⚠️ No Changeset found

Latest commit: 5d34899

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix Windows release failures by aligning the CI Node.js version with the engine requirements specified in package.json (Node ≥24). The change updates the Windows asset upload workflow to use .nvmrc for determining the Node version instead of the hardcoded Node 20.

Changes:

  • Updates the Windows build step in the release asset upload workflow to read Node version from .nvmrc file instead of using a hardcoded version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Varadraj75
Copy link
Contributor Author

hey @Shurtu-gal ,
I have opened a PR fixing the CI Node version issue all relevant tests are passing
would appreciate a review when you have time. Thanks!

Copy link
Collaborator

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at other workflows as well in case we are missing node version fix.

uses: actions/setup-node@v4
with:
node-version: 20
node-version-file: '.nvmrc'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have nvmrc file.

You can use this instead.

- if: steps.packagejson.outputs.exists == 'true'
name: Check package-lock version
uses: asyncapi/.github/.github/actions/get-node-version-from-package-lock@master
id: lockversion
with:
node-version: ${{ vars.NODE_VERSION }}
- if: steps.packagejson.outputs.exists == 'true'
name: Setup Node.js
uses: actions/setup-node@v6
with:
node-version: "${{ steps.lockversion.outputs.version }}"

@github-project-automation github-project-automation bot moved this from To Triage to Backlog in CLI - Kanban Jan 29, 2026
@sonarqubecloud
Copy link

@Varadraj75
Copy link
Contributor Author

Sorry about that @Shurtu-gal — I missed cross-checking this earlier.

I have now updated the workflow to remove the .nvmrc usage and aligned the Node version setup with the pattern used in release-with-changesets.yml. All checks are passing, and I also verified the fix locally.

Could you please take another look when you have time? Thanks!

@Shurtu-gal Shurtu-gal changed the title ci: fix Windows release by aligning Node version with engine requirements fix: windows release by aligning Node version with engine requirements Jan 29, 2026
@Shurtu-gal Shurtu-gal merged commit f25d849 into asyncapi:master Jan 29, 2026
25 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in CLI - Kanban Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[BUG] Windows CLI download link on website returns 404

2 participants