[BUG] 2.17.0 & 3.1.1 asyncapi bundle & optimise breaks fifo channels

[zbigniew-malcherczyk-tg]

Describe the bug.

The AWS SNS topics and queues can be (first in first out) FIFO. To define such their name must end with .fifo (example user-created.fifo)

Content:

# asyncapi.yaml
asyncapi: 2.0.0
info:
  title: Service
  version: 1.0.0

channels:
  '{ENV}-user-created.fifo':
    publish:
      message:
        $ref: '#/components/messages/UserCreated'

components:
  messages:
    UserCreated:
      $ref: 'UserCreated.yaml'

# UserCreated.yaml
payload:
  type: object
  properties:
    eventName:
      type: string
      description: The name of the event.

Execute:

asyncapi bundle asyncapi.yaml -x -o output.yaml

Then Execute:

asyncapi optimize output.yaml --optimization=reuse-components -o=overwrite --no-tty

The result is invalid Async API document:

asyncapi: 2.0.0
info:
  title: Remittance
  version: 1.0.0
channels:
  '{ENV}-user-created.fifo':
    publish:
      message:
        payload:
          type: object
          properties:
            eventName:
              type: string
              description: The name of the event.
        x-origin: UserCreated.yaml
  '{ENV}-user-created':
    fifo:
      publish:
        message:
          $ref: '#/components/messages/UserCreated'
components:
  messages:
    UserCreated:
      payload:
        type: object
        properties:
          eventName:
            type: string
            description: The name of the event.
      x-origin: UserCreated.yaml

Expected behavior

👀 Have you checked for similar open issues?

• I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

• I have read the Contributing Guidelines

Are you willing to work on this issue ?

None

[github-actions]

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

[zbigniew-malcherczyk-tg]

For some reason not all .fifo are broken like that. But when its broken the FIFO topic/queue is present alongside with none-broken... so it's like duplicating the channels

[Souvikns]

This error is happening due to optimizer, i will look into the optimizer repo and figure out a solution.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

[neoandmatrix]

Hey @zbigniew-malcherczyk-tg are you still facing the issue with the latest version?

[zbigniew-malcherczyk-tg]

@neoandmatrix Yup. Checked with version 4.0.0 and its still there 😢