..

Author: rogeralsing

continue.md

@@ -29,6 +29,7 @@
 - Module evaluation now walks requested modules ahead of body execution, ResolveExport/export\* follow the spec (cycle-aware, ambiguous names filtered), module namespaces expose unambiguous exports only, and namespace [[Set]]/Reflect.set return false instead of throwing.
 - Object destructuring rest now walks [[OwnPropertyKeys]] with exclusions checked before GetOwnPropertyDescriptor, skips Get for non-enumerables, and uses the original object (including proxies) instead of cloning; the proxy rest destructuring get/gOPD/ownKeys-order tests are passing.
 - Async functions now resolve their completion through the global Promise constructor even when executed from nested scopes (class/field environments fall back to the root global object), so the async class element clusters involving same-line static async methods/private names are green again.
+- Parameter environments now hang off their function environments so default-parameter `super`/`this` lookups see the right bindings, and sloppy generator methods coerce `this` to the realm global object; the object method definition default-super/sloppy-this generators are passing.
 
 ## Next Iteration Plan
 1. When resuming broader work, run a narrow Language filter outside `ArgumentsObject`/`Array_fromAsync` to find the next hot cluster (avoid full 43k sweep).

languagetests.md

@@ -35,14 +35,6 @@
         Expressions_prefixDecrement("language/expressions/prefix-decrement/eval-nostrict.js",False)
        Expressions_prefixIncrement
         Expressions_prefixIncrement("language/expressions/prefix-increment/eval-nostrict.js",False)
-       Expressions_super
-        Expressions_super("language/expressions/super/call-arg-evaluation-err.js",False)
-        Expressions_super("language/expressions/super/call-construct-invocation.js",False)
-        Expressions_super("language/expressions/super/call-construct-invocation.js",True)
-        Expressions_super("language/expressions/super/prop-expr-getsuperbase-before-topropertykey-putvalue-increment.js",False)
-        Expressions_super("language/expressions/super/prop-expr-getsuperbase-before-topropertykey-putvalue-increment.js",True)
-        Expressions_super("language/expressions/super/realm.js",False)
-        Expressions_super("language/expressions/super/realm.js",True)
        Expressions_yield
         Expressions_yield("language/expressions/yield/star-rhs-iter-thrw-res-done-no-value.js",False)
         Expressions_yield("language/expressions/yield/star-rhs-iter-thrw-res-done-no-value.js",True)
@@ -54,6 +46,7 @@
        FutureReservedWords
         FutureReservedWords("language/future-reserved-words/static.js",False)
        GlobalCode
+        GlobalCode("language/global-code/decl-lex-restricted-global.js",True)
         GlobalCode("language/global-code/script-decl-func-err-non-extensible.js",False)
         GlobalCode("language/global-code/script-decl-func-err-non-extensible.js",True)
         GlobalCode("language/global-code/script-decl-lex-var-declared-via-eval.js",False)
@@ -62,6 +55,10 @@
         ModuleCode_topLevelAwait("language/module-code/top-level-await/await-dynamic-import-resolution.js",True)
         ModuleCode_topLevelAwait("language/module-code/top-level-await/module-graphs-does-not-hang.js",True)
        ModuleCode_topLevelAwait_syntax
+        ModuleCode_topLevelAwait_syntax("language/module-code/top-level-await/syntax/await-expr-dyn-import.js",True)
+       ReservedWords
+        ReservedWords("language/reserved-words/unreserved-words.js",False)
+        ReservedWords("language/reserved-words/unreserved-words.js",True)
        Statements_asyncGenerator
         Statements_asyncGenerator("language/statements/async-generator/yield-star-async-from-sync-iterator-inaccessible.js",False)
         Statements_asyncGenerator("language/statements/async-generator/yield-star-async-from-sync-iterator-inaccessible.js",True)

src/Asynkron.JsEngine/Ast/TypedAstEvaluator.TypedFunction.cs

@@ -462,19 +462,16 @@ public bool TryDefineProperty(string name, PropertyDescriptor descriptor)
             JsEnvironment functionEnvironment;
             if (hasParameterExpressions)
             {
-                parameterEnvironment = new JsEnvironment(_closure, true, _isStrict, _function.Source,
+                functionEnvironment = new JsEnvironment(_closure, true, _isStrict, _function.Source,
+                    description);
+                functionEnvironment.SetBodyLexicalNames(bodyLexicalNames);
+
+                // Hang the parameter environment off the function environment so defaults
+                // can see `this`/super/new.target while still isolating their bindings
+                // from the body’s var environment.
+                parameterEnvironment = new JsEnvironment(functionEnvironment, false, _isStrict, _function.Source,
                     description, isParameterEnvironment: true);
                 parameterEnvironment.SetBodyLexicalNames(bodyLexicalNames);
-                functionEnvironment = new JsEnvironment(parameterEnvironment, true, _isStrict,
-                    _function.Source, description);
-                functionEnvironment.SetBodyLexicalNames(bodyLexicalNames);
-                // Parameter expressions (including direct eval) should use the
-                // dedicated parameter environment as their variable environment
-                // (ES 10.2.11, FunctionDeclarationInstantiation step 14 when
-                // HasParameterExpressions is true). This keeps var bindings created
-                // during parameter evaluation (e.g. `eval("var arguments = ...")`)
-                // separate from the function body’s var environment so later body
-                // declarations do not overwrite them.
             }
             else
             {
@@ -484,7 +481,7 @@ public bool TryDefineProperty(string name, PropertyDescriptor descriptor)
                 parameterEnvironment = functionEnvironment;
             }
 
-            var executionEnvironment = new JsEnvironment(functionEnvironment, false, _isStrict,
+            var executionEnvironment = new JsEnvironment(parameterEnvironment, false, _isStrict,
                 _function.Source, description, isBodyEnvironment: true);
             executionEnvironment.SetBodyLexicalNames(bodyLexicalNames);
 

src/Asynkron.JsEngine/Ast/TypedAstEvaluator.TypedGeneratorInstance.cs

@@ -219,12 +219,13 @@ private JsEnvironment CreateExecutionEnvironment()
             JsEnvironment functionEnvironment;
             if (hasParameterExpressions)
             {
-                parameterEnvironment = new JsEnvironment(_closure, true, _isStrict, _function.Source,
+                functionEnvironment = new JsEnvironment(_closure, true, _isStrict, _function.Source,
+                    description);
+                functionEnvironment.SetBodyLexicalNames(bodyLexicalNames);
+
+                parameterEnvironment = new JsEnvironment(functionEnvironment, false, _isStrict, _function.Source,
                     description, isParameterEnvironment: true);
                 parameterEnvironment.SetBodyLexicalNames(bodyLexicalNames);
-                functionEnvironment = new JsEnvironment(parameterEnvironment, true, _isStrict,
-                    _function.Source, description);
-                functionEnvironment.SetBodyLexicalNames(bodyLexicalNames);
             }
             else
             {
@@ -234,23 +235,52 @@ private JsEnvironment CreateExecutionEnvironment()
                 parameterEnvironment = functionEnvironment;
             }
 
-            var executionEnvironment = new JsEnvironment(functionEnvironment, false, _isStrict,
+            var executionEnvironment = new JsEnvironment(parameterEnvironment, false, _isStrict,
                 _function.Source, description, isBodyEnvironment: true);
             executionEnvironment.SetBodyLexicalNames(bodyLexicalNames);
 
-            functionEnvironment.Define(Symbol.This, _thisValue ?? new JsObject());
+            var generatorContext = _realmState.CreateContext(
+                ScopeKind.Function,
+                DetermineGeneratorScopeMode(),
+                true);
+
+            object? boundThis = _thisValue;
+            if (!_isStrict)
+            {
+                if (boundThis is null || ReferenceEquals(boundThis, Symbol.Undefined))
+                {
+                    boundThis = _realmState.Engine?.GlobalObject;
+                    boundThis ??= Symbol.Undefined;
+                }
+
+                if (boundThis is null)
+                {
+                    boundThis = new JsObject
+                    {
+                        RealmState = _realmState
+                    };
+                }
+                else if (boundThis is not IJsPropertyAccessor &&
+                         !IsNullish(boundThis) &&
+                         boundThis is not IIsHtmlDda)
+                {
+                    boundThis = ToObjectForDestructuring(boundThis, generatorContext);
+                }
+            }
+
+            functionEnvironment.Define(Symbol.This, boundThis);
             functionEnvironment.Define(Symbol.YieldResumeContextSymbol, _resumeContext);
             functionEnvironment.Define(Symbol.GeneratorInstanceSymbol, this);
 
             var superPrototype = _homeObject?.Prototype;
-            if (superPrototype is null && _thisValue is JsObject thisObj)
+            if (superPrototype is null && boundThis is JsObject thisObj)
             {
                 superPrototype = thisObj.Prototype;
             }
 
             if (superPrototype is not null)
             {
-                var superBinding = new SuperBinding(null, superPrototype, _thisValue, true);
+                var superBinding = new SuperBinding(null, superPrototype, boundThis, true);
                 functionEnvironment.Define(Symbol.Super, superBinding);
             }
 
@@ -268,10 +298,6 @@ private JsEnvironment CreateExecutionEnvironment()
                 parameterEnvironment.Define(functionName, _callable, isConst: true, isLexical: true, blocksFunctionScopeOverride: true);
             }
 
-            var generatorContext = _realmState.CreateContext(
-                ScopeKind.Function,
-                DetermineGeneratorScopeMode(),
-                true);
             generatorContext.BlockedFunctionVarNames = blockedFunctionVarNames;
             HoistVarDeclarations(_function.Body, executionEnvironment, generatorContext,
                 lexicalNames: lexicalNames,