Improve unmanaged code labeling in call tree

Author: rogeralsing

src/ProfileTool/Program.cs

@@ -2457,7 +2457,7 @@ void CollectTimelineRows(
     int maxWidth)
 {
     var matchName = GetCallTreeMatchName(node);
-    var displayName = NameFormatter.FormatMethodDisplayName(matchName);
+    var displayName = GetCallTreeDisplayName(matchName);
 
     var timeSpent = isRoot && useSelfTime
         ? GetCallTreeTime(node, useSelfTime: false)
@@ -2607,7 +2607,7 @@ string FormatCallTreeLine(
     int depth = 0)
 {
     var matchName = GetCallTreeMatchName(node);
-    var displayName = matchName;
+    var displayName = GetCallTreeDisplayName(matchName);
 
     // Calculate max name length based on actual depth (shallower = more space)
     int maxNameLen;
@@ -2795,7 +2795,7 @@ string FormatExceptionCallTreeLine(
     var matchName = GetCallTreeMatchName(node);
     var displayName = isRoot && !string.IsNullOrWhiteSpace(rootLabelOverride)
         ? rootLabelOverride
-        : matchName;
+        : GetCallTreeDisplayName(matchName);
     if (displayName.Length > 80)
     {
         displayName = displayName[..77] + "...";
@@ -3002,7 +3002,8 @@ string FormatCallTreeName(string displayName, string matchName, bool isLeaf)
     }
 
     const string leafHighlightColor = "plum1";
-    if (matchName.Contains("CastHelpers.", StringComparison.Ordinal))
+    if (matchName.Contains("CastHelpers.", StringComparison.Ordinal) ||
+        matchName.Contains("UNMANAGED_CODE_TIME", StringComparison.Ordinal))
     {
         return $"[{leafHighlightColor}]{escaped}[/]";
     }
@@ -3034,9 +3035,20 @@ string GetCallTreeMatchName(CallTreeNode node)
     return NameFormatter.FormatMethodDisplayName(node.Name);
 }
 
+string GetCallTreeDisplayName(string matchName)
+{
+    if (matchName.Contains("UNMANAGED_CODE_TIME", StringComparison.Ordinal))
+    {
+        return "Unmanaged Code";
+    }
+
+    return matchName;
+}
+
 bool ShouldStopAtLeaf(string matchName)
 {
     return matchName.Contains("CastHelpers.", StringComparison.Ordinal) ||
+           matchName.Contains("UNMANAGED_CODE_TIME", StringComparison.Ordinal) ||
            matchName.Contains("Array.Copy", StringComparison.Ordinal) ||
            matchName.Contains("Dictionary<__Canon,__Canon>.Resize", StringComparison.Ordinal) ||
            matchName.Contains("Buffer.BulkMoveWithWriteBarrier", StringComparison.Ordinal) ||

src/ProfileTool/Rendering/NameFormatter.cs

@@ -12,16 +12,10 @@ public static string FormatMethodDisplayName(string rawName)
             return rawName;
         }
 
-        var name = rawName;
+        var name = StripParameterList(rawName);
         if (name.Contains('!'))
         {
-            name = name.Split('!')[^1];
-        }
-
-        var parenIdx = name.IndexOf('(');
-        if (parenIdx > 0)
-        {
-            name = name[..parenIdx];
+            name = StripParameterList(name.Split('!')[^1]);
         }
 
         var lastDot = name.LastIndexOf('.');
@@ -35,10 +29,11 @@ public static string FormatMethodDisplayName(string rawName)
                 return compilerGenerated;
             }
 
-            return $"{CleanTypeName(typePart)}.{methodPart}";
+            var formatted = $"{CleanTypeName(typePart)}.{methodPart}";
+            return EnsureReadableName(formatted);
         }
 
-        return CleanTypeName(name);
+        return EnsureReadableName(CleanTypeName(name));
     }
 
     public static string FormatTypeDisplayName(string rawName)
@@ -82,6 +77,92 @@ private static string CleanTypeName(string name)
         return normalized;
     }
 
+    private static string StripParameterList(string name)
+    {
+        if (string.IsNullOrWhiteSpace(name))
+        {
+            return name;
+        }
+
+        var trimmed = name.Trim();
+        var parenIdx = trimmed.IndexOf('(');
+        if (parenIdx >= 0)
+        {
+            trimmed = trimmed[..parenIdx];
+        }
+        else
+        {
+            var cutIdx = FindFirstTopLevelSeparator(trimmed);
+            if (cutIdx >= 0)
+            {
+                trimmed = trimmed[..cutIdx];
+            }
+        }
+
+        return trimmed.TrimEnd(')', '&', ',', ' ');
+    }
+
+    private static string EnsureReadableName(string name)
+    {
+        var trimmed = name?.Trim() ?? string.Empty;
+        if (!HasLetter(trimmed))
+        {
+            return "Unmanaged Code";
+        }
+
+        return trimmed;
+    }
+
+    private static int FindFirstTopLevelSeparator(string name)
+    {
+        var squareDepth = 0;
+        var angleDepth = 0;
+
+        for (var i = 0; i < name.Length; i++)
+        {
+            var ch = name[i];
+            switch (ch)
+            {
+                case '[':
+                    squareDepth++;
+                    break;
+                case ']':
+                    if (squareDepth > 0)
+                    {
+                        squareDepth--;
+                    }
+                    break;
+                case '<':
+                    angleDepth++;
+                    break;
+                case '>':
+                    if (angleDepth > 0)
+                    {
+                        angleDepth--;
+                    }
+                    break;
+                case ',' when squareDepth == 0 && angleDepth == 0:
+                case ')' when squareDepth == 0 && angleDepth == 0:
+                    return i;
+            }
+        }
+
+        return -1;
+    }
+
+    private static bool HasLetter(string value)
+    {
+        foreach (var ch in value)
+        {
+            if (char.IsLetter(ch))
+            {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
     private static string? FormatCompilerGeneratedMethod(string typePart, string methodPart)
     {
         if (string.IsNullOrWhiteSpace(typePart) || string.IsNullOrWhiteSpace(methodPart))

tests/Asynkron.Profiler.Tests/NameFormatterTests.cs

@@ -10,6 +10,9 @@ public sealed class NameFormatterTests
     [InlineData("PromiseConstructor.<AttachStatics>b__5_0", "PromiseConstructor.AttachStatics lambda")]
     [InlineData("Asynkron.JsEngine.Ast.TypedAstEvaluator+TypedFunction.InvokeWithContext2(System.Int32)",
         "TypedAstEvaluator.TypedFunction.InvokeWithContext2")]
+    [InlineData("0)", "Unmanaged Code")]
+    [InlineData("0[]&,int32)", "Unmanaged Code")]
+    [InlineData("0&,unsigned int)", "Unmanaged Code")]
     public void FormatsMethodNames(string raw, string expected)
     {
         var actual = NameFormatter.FormatMethodDisplayName(raw);