diff --git a/src/Proto.Actor/Context/ActorContext.cs b/src/Proto.Actor/Context/ActorContext.cs index 7c3d010e12..2bfe582b0c 100644 --- a/src/Proto.Actor/Context/ActorContext.cs +++ b/src/Proto.Actor/Context/ActorContext.cs @@ -205,7 +205,7 @@ public void Forward(PID target) public void Request(PID target, object message, PID? sender) { - var messageEnvelope = MessageEnvelope.WithSender(message, sender!); + var messageEnvelope = MessageEnvelope.WithSender(message, sender); SendUserMessage(target, messageEnvelope); } diff --git a/src/Proto.Actor/EventStream/EventProbeLogMessages.cs b/src/Proto.Actor/EventStream/EventProbeLogMessages.cs index 6c2cf9c1ee..7827b69921 100644 --- a/src/Proto.Actor/EventStream/EventProbeLogMessages.cs +++ b/src/Proto.Actor/EventStream/EventProbeLogMessages.cs @@ -8,8 +8,8 @@ internal static partial class EventProbeLogMessages internal static partial void SettingExpectation(this ILogger logger); [LoggerMessage(1, LogLevel.Debug, "Got expected event {Event}")] - internal static partial void GotExpectedEvent(this ILogger logger, object @event); + internal static partial void GotExpectedEvent(this ILogger logger, object? @event); [LoggerMessage(2, LogLevel.Debug, "Got unexpected {Event}, ignoring")] - internal static partial void GotUnexpectedEvent(this ILogger logger, object @event); + internal static partial void GotUnexpectedEvent(this ILogger logger, object? @event); } diff --git a/src/Proto.Actor/Messages/MessageEnvelope.cs b/src/Proto.Actor/Messages/MessageEnvelope.cs index 03a6dedde8..0d3b09d0ed 100644 --- a/src/Proto.Actor/Messages/MessageEnvelope.cs +++ b/src/Proto.Actor/Messages/MessageEnvelope.cs @@ -67,17 +67,17 @@ public static MessageEnvelope Wrap(object message, MessageHeader header) => mess /// /// Adds a sender to the message envelope. /// - /// + /// Sender or null /// New envelope - public MessageEnvelope WithSender(PID sender) => this with { Sender = sender }; + public MessageEnvelope WithSender(PID? sender) => this with { Sender = sender }; /// /// Adds a sender if the message is an envelope, otherwise creates a new envelope with the given sender. /// /// - /// + /// Sender or null /// New envelope - public static MessageEnvelope WithSender(object message, PID sender) => message is MessageEnvelope env + public static MessageEnvelope WithSender(object message, PID? sender) => message is MessageEnvelope env ? env.WithSender(sender) : new MessageEnvelope(message, sender); diff --git a/src/Proto.Actor/Supervision/AllForOneStrategyLogMessages.cs b/src/Proto.Actor/Supervision/AllForOneStrategyLogMessages.cs index 49aed59022..991e8048bf 100644 --- a/src/Proto.Actor/Supervision/AllForOneStrategyLogMessages.cs +++ b/src/Proto.Actor/Supervision/AllForOneStrategyLogMessages.cs @@ -5,7 +5,7 @@ namespace Proto; internal static partial class AllForOneStrategyLogMessages { - // `reason` is kept so the logger captures the exception automatically + // "exception" parameter ensures the exception is logged automatically [LoggerMessage(0, LogLevel.Information, "{Action} {Actor}")] - internal static partial void AllForOneStrategyAction(this ILogger logger, string action, PID actor, Exception reason); + internal static partial void AllForOneStrategyAction(this ILogger logger, string action, PID actor, Exception exception); } diff --git a/src/Proto.Actor/Supervision/OneForOneStrategyLogMessages.cs b/src/Proto.Actor/Supervision/OneForOneStrategyLogMessages.cs index 5fd8014cef..76ce2417a9 100644 --- a/src/Proto.Actor/Supervision/OneForOneStrategyLogMessages.cs +++ b/src/Proto.Actor/Supervision/OneForOneStrategyLogMessages.cs @@ -5,7 +5,7 @@ namespace Proto; internal static partial class OneForOneStrategyLogMessages { - // `reason` is kept so the logger captures the exception automatically + // "exception" parameter ensures the exception is logged automatically [LoggerMessage(0, LogLevel.Information, "{Action} {Actor}")] - internal static partial void OneForOneStrategyAction(this ILogger logger, string action, PID actor, Exception reason); + internal static partial void OneForOneStrategyAction(this ILogger logger, string action, PID actor, Exception exception); }