xpadneo: Remove deprecated ida_simple_xx() usage

Update to use ida_alloc() and ida_free() in place of the deprecated
ida_simple_get() and ida_simple_remove() calls. Linux has removed this
API in the v6.18 release candidates. ida_simple_xx() has been deprecated since
v5.10 and the new API was introduced in v4.19.

Closes: #562
Signed-off-by: Kai Krakow <[email protected]>

Author: kakra

docs/README.md

@@ -44,10 +44,12 @@ These other projects may not support some of the advanced features of xpadneo.
 
 ## Breaking Changes
 
-### Kernel 4.18 or newer required
+### Kernel 4.19 or newer required
 
-As of xpadneo v0.10, we require kernel 4.18 or later to utilize `HID_QUIRK_INPUT_PER_APP` which splits the gamepad into
-multiple sub-devices to fix problems and incompatibilities at several layers.
+As of xpadneo v0.10, we require kernel 4.19 or later to utilize `HID_QUIRK_INPUT_PER_APP` (available in kernel 4.18+)
+which splits the gamepad into multiple sub-devices to fix problems and incompatibilities at several layers. We also
+require `ida_simple_{alloc,free}()` (available since kernel 4.19) which has been deprecated since kernel 5.10, and is
+no longer available in kernel 6.18+.
 
 
 ### SDL2 2.28 Compatibility

hid-xpadneo/src/hid-xpadneo.c

@@ -1235,7 +1235,7 @@ static int xpadneo_probe(struct hid_device *hdev, const struct hid_device_id *id
 	if (xdata == NULL)
 		return -ENOMEM;
 
-	index = ida_simple_get(&xpadneo_device_id_allocator, 0, 0, GFP_KERNEL);
+	index = ida_alloc(&xpadneo_device_id_allocator, GFP_KERNEL);
 	if (index < 0)
 		return index;
 	xdata->id = index;
@@ -1344,7 +1344,7 @@ static int xpadneo_probe(struct hid_device *hdev, const struct hid_device_id *id
 static void xpadneo_release_device_id(struct xpadneo_devdata *xdata)
 {
 	if (xdata->id >= 0) {
-		ida_simple_remove(&xpadneo_device_id_allocator, xdata->id);
+		ida_free(&xpadneo_device_id_allocator, xdata->id);
 		xdata->id = -1;
 	}
 }

hid-xpadneo/src/xpadneo.h

@@ -16,7 +16,11 @@
 
 #include "hid-ids.h"
 
-#if LINUX_VERSION_CODE < KERNEL_VERSION(4,18,0)
+#if LINUX_VERSION_CODE < KERNEL_VERSION(4, 19, 0)
+#error "kernel version 4.19.0+ required for ida_simple_{alloc,free}()"
+#endif
+
+#if LINUX_VERSION_CODE < KERNEL_VERSION(4, 18, 0)
 #error "kernel version 4.18.0+ required for HID_QUIRK_INPUT_PER_APP"
 #endif