Skip to content

Commit ee6e42b

Browse files
#11 Remove mapping of PhantomJSDriver
1 parent 26a1f50 commit ee6e42b

File tree

7 files changed

+2
-33
lines changed

7 files changed

+2
-33
lines changed

README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -258,13 +258,13 @@ string sectionBoolValue = AppConfig.Current.Section.BoolProperty;
258258
}
259259
],
260260
"driver": { // Use "driver" for single driver support.
261-
"type": "chrome", // Supports: "remote", "chrome", "firefox", "internetexplorer", "safari", "opera", "edge", "phantomjs" and custom mappers registered via DriverJsonMapperAliases.Register method.
261+
"type": "chrome", // Supports: "remote", "chrome", "firefox", "internetexplorer", "safari", "opera", "edge" and custom mappers registered via DriverJsonMapperAliases.Register method.
262262
// Custom RemoteWebDriver type can also be passed as a full type name, e.g.: "Namespace.Class, MyAssembly".
263263
"alias": "custom_alias", // Use aliases when you have several drivers of the same type.
264264
"remoteAddress": "http://127.0.0.1:8888/wd/hub", // Remote driver specific.
265265
"options": { // Configures driver options.
266266
"type": "chome", // Remote driver specific.
267-
// Supports: chrome, firefox, internetexplorer, safari, opera, edge, phantomjs.
267+
// Supports: chrome, firefox, internetexplorer, safari, opera, edge.
268268
"loggingPreferences": { // Dictionary of logType and logLevel.
269269
// Invokes SetLoggingPreference method of DriverOptions for each item.
270270
"browser": "Info",
@@ -356,7 +356,6 @@ string sectionBoolValue = AppConfig.Current.Section.BoolProperty;
356356
"service": { // Configures driver service.
357357
"driverPath": "string",
358358
"driverExecutableFileName": "string",
359-
"arguments": [ "string", "string" ], // PhantomJS specific.
360359
"{{driverServicePropertyName}}": "value" // Any property of driver specific service (e.g.: ChromeDriverService).
361360
},
362361
"commandTimeout": 60 // Sets the command timeout in seconds.

src/Atata.Configuration.Json.Tests/Atata.Configuration.Json.Tests.csproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,13 +179,11 @@
179179
<PropertyGroup>
180180
<ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
181181
</PropertyGroup>
182-
<Error Condition="!Exists('..\packages\Selenium.PhantomJS.WebDriver.2.1.1\build\Selenium.PhantomJS.WebDriver.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Selenium.PhantomJS.WebDriver.2.1.1\build\Selenium.PhantomJS.WebDriver.targets'))" />
183182
<Error Condition="!Exists('..\packages\Selenium.WebDriver.MicrosoftDriver.16.16299.0\build\Selenium.WebDriver.MicrosoftDriver.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Selenium.WebDriver.MicrosoftDriver.16.16299.0\build\Selenium.WebDriver.MicrosoftDriver.targets'))" />
184183
<Error Condition="!Exists('..\packages\Selenium.Firefox.WebDriver.0.19.1\build\Selenium.Firefox.WebDriver.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Selenium.Firefox.WebDriver.0.19.1\build\Selenium.Firefox.WebDriver.targets'))" />
185184
<Error Condition="!Exists('..\packages\NUnit.3.10.1\build\NUnit.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\NUnit.3.10.1\build\NUnit.props'))" />
186185
<Error Condition="!Exists('..\packages\NUnit3TestAdapter.3.10.0\build\net35\NUnit3TestAdapter.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\NUnit3TestAdapter.3.10.0\build\net35\NUnit3TestAdapter.props'))" />
187186
</Target>
188-
<Import Project="..\packages\Selenium.PhantomJS.WebDriver.2.1.1\build\Selenium.PhantomJS.WebDriver.targets" Condition="Exists('..\packages\Selenium.PhantomJS.WebDriver.2.1.1\build\Selenium.PhantomJS.WebDriver.targets')" />
189187
<ItemGroup>
190188
<Content Include="..\packages\WebDriver.ChromeDriver.win32.2.35.0\content\chromedriver.exe">
191189
<Link>chromedriver.exe</Link>

src/Atata.Configuration.Json.Tests/packages.config

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
<package id="NUnit" version="3.10.1" targetFramework="net40" />
99
<package id="NUnit3TestAdapter" version="3.10.0" targetFramework="net40" />
1010
<package id="Selenium.Firefox.WebDriver" version="0.19.1" targetFramework="net40" />
11-
<package id="Selenium.PhantomJS.WebDriver" version="2.1.1" targetFramework="net40" />
1211
<package id="Selenium.WebDriver" version="3.12.1" targetFramework="net40" />
1312
<package id="Selenium.WebDriver.MicrosoftDriver" version="16.16299.0" targetFramework="net40" />
1413
<package id="StyleCop.Analyzers" version="1.0.2" targetFramework="net40" developmentDependency="true" />

src/Atata.Configuration.Json/DriverServiceJsonSection.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,5 @@ public class DriverServiceJsonSection : JsonSection
55
public string DriverPath { get; set; }
66

77
public string DriverExecutableFileName { get; set; }
8-
9-
// PhantomJS specific.
10-
public string[] Arguments { get; set; }
118
}
129
}

src/Atata.Configuration.Json/Mapping/DriverJsonMapperAliases.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ static DriverJsonMapperAliases()
1616
Register<SafariDriverJsonMapper>(DriverAliases.Safari);
1717
Register<OperaDriverJsonMapper>(DriverAliases.Opera);
1818
Register<EdgeDriverJsonMapper>(DriverAliases.Edge);
19-
Register<PhantomJSDriverJsonMapper>(DriverAliases.PhantomJS);
2019
}
2120

2221
public static void Register<T>(string alias)

src/Atata.Configuration.Json/Mapping/PhantomJSDriverJsonMapper.cs

Lines changed: 0 additions & 21 deletions
This file was deleted.

src/Atata.Configuration.Json/Mapping/RemoteDriverJsonMapper.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,6 @@ private IDriverJsonMapper GetOptionsMapper(string typeName)
5454
return new OperaDriverJsonMapper();
5555
case DriverAliases.Edge:
5656
return new EdgeDriverJsonMapper();
57-
case DriverAliases.PhantomJS:
58-
return new PhantomJSDriverJsonMapper();
5957
case null:
6058
throw new ArgumentNullException(nameof(typeName), "Options type name is not defined.");
6159
default:

0 commit comments

Comments
 (0)