Skip to content

Commit 4121285

Browse files
committed
fix comments
1 parent 8e59e28 commit 4121285

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

atcoder/internal_bit.hpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,15 @@ namespace atcoder {
99

1010
namespace internal {
1111

12+
// @return same with std::bit::bit_ceil
1213
unsigned int bit_ceil(unsigned int n) {
1314
unsigned int x = 1;
1415
while (x < (unsigned int)(n)) x *= 2;
1516
return x;
1617
}
1718

1819
// @param n `1 <= n`
19-
// @return minimum non-negative `x` s.t. `(n & (1 << x)) != 0`
20+
// @return same with std::bit::countr_zero
2021
int countr_zero(unsigned int n) {
2122
#ifdef _MSC_VER
2223
unsigned long index;
@@ -28,7 +29,7 @@ int countr_zero(unsigned int n) {
2829
}
2930

3031
// @param n `1 <= n`
31-
// @return minimum non-negative `x` s.t. `(n & (1 << x)) != 0`
32+
// @return same with std::bit::countr_zero
3233
constexpr int countr_zero_constexpr(unsigned int n) {
3334
int x = 0;
3435
while (!(n & (1 << x))) x++;

test/unittest/bit_test.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,10 @@ TEST(BitTest, BitCeil) {
1919
ASSERT_EQ(8, internal::bit_ceil(7U));
2020
ASSERT_EQ(8, internal::bit_ceil(8U));
2121
ASSERT_EQ(16, internal::bit_ceil(9U));
22-
ASSERT_EQ(1U<<30, internal::bit_ceil(1U << 30));
23-
ASSERT_EQ(1U<<31, internal::bit_ceil((1U << 30) + 1));
24-
ASSERT_EQ(1U<<31, internal::bit_ceil((1U << 31) - 1));
22+
ASSERT_EQ(1U << 30, internal::bit_ceil(1U << 30));
23+
ASSERT_EQ(1U << 31, internal::bit_ceil((1U << 30) + 1));
24+
ASSERT_EQ(1U << 31, internal::bit_ceil((1U << 31) - 1));
25+
ASSERT_EQ(1U << 31, internal::bit_ceil(1U << 31));
2526
}
2627

2728
TEST(BitTest, CountrZero) {

0 commit comments

Comments
 (0)