Issue #87 add tests for masking passwords in toString()

Alex Collins · Alex Collins · commit e36bf9a40b3f · 2014-09-28T12:44:40.000+01:00
diff --git a/test/unit/docker/registry/web/RegistrySpec.groovy b/test/unit/docker/registry/web/RegistrySpec.groovy
@@ -149,4 +149,13 @@ class RegistrySpec extends Specification {
         "username".equals(registry.username)
         registry.password == null
     }
+
+    void "test toString doesn't contain password :)"() {
+        when:
+        def registryStr = Registry.fromUrl("http://admin:abc123@172.17.42.1:5000/v1/").toString()
+        then:
+        registryStr != null
+        !registryStr.contains("abc123")
+        registryStr.contains("******") // * replaces abc123
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -149,4 +149,13 @@ class RegistrySpec extends Specification {`
`149`	`149`	`"username".equals(registry.username)`
`150`	`150`	`registry.password == null`
`151`	`151`	`}`
	`152`	`+`
	`153`	`+ void "test toString doesn't contain password :)"() {`
	`154`	`+ when:`
	`155`	`+ def registryStr = Registry.fromUrl("http://admin:abc123@172.17.42.1:5000/v1/").toString()`
	`156`	`+ then:`
	`157`	`+ registryStr != null`
	`158`	`+ !registryStr.contains("abc123")`
	`159`	`+ registryStr.contains("*****") // replaces abc123`
	`160`	`+ }`
`152`	`161`	`}`