Skip to content

Commit 80bbcc3

Browse files
author
Carlos Atencio
committed
Adding contribution guidelines
1 parent 29f21bf commit 80bbcc3

File tree

2 files changed

+14
-13
lines changed

2 files changed

+14
-13
lines changed

CONTRIBUTING.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# Contributing to protractor-http-mock
2+
This project has come a long way thanks to the community, and its growth has been very much a result from countless suggestions and pull requests. Thank you all!
3+
4+
## Pull Requests
5+
I strongly encourage developers to submit pull requests for new features and bug fixes. Please add unit tests and/or an examples to any pull request submitted. This goes a long way in getting the pull request merged in as soon as possible.
6+
7+
This project is developed using grunt. To run all tests, simply execute
8+
9+
`npm install`
10+
`node_modules/.bin/webdriver-manager update`
11+
`grunt verify`
12+
13+
* To add a unit test, please refer to tests/httpMock.test.js
14+
* To add an example, please refer to the example/ folder.

README.md

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -212,16 +212,3 @@ To run these tests locally, please follow these steps from the root directory:
212212
1. `npm install`
213213
2. `node_modules/.bin/webdriver-manager update`
214214
3. `npm run example`
215-
216-
217-
### Contributions and recognition
218-
219-
* `jdgblinq` for their contribution to query string matching.
220-
* `ReactiveRaven` for adding convenience methods key for getting this to work with ngResource.
221-
* `nielssj` for the `requestsMade` functionality and for pointing out a few bugs.
222-
* `nadersoliman` for their input and pull request on allowing the user to set custom name for the protractor configuration file.
223-
* `kharnt0x` for submitting a bug fix for proper callback handling.
224-
* `zigzackattack` for their contribution on post data matching.
225-
* `matthewjh` for their pull request to allow the plugin to play nice with interceptors.
226-
* `stevehenry13` for their pull request to allow the plugin to work with transforms.
227-
* `brandonroberts` for the fantastic work on interceptors and promises.

0 commit comments

Comments
 (0)