Merge pull request #97 from shssoichiro/handle-response-error-interceptors

Apply response error interceptors to mocked responses

Author: atecarlos

lib/httpMock.js

@@ -17,6 +17,10 @@ function mockTemplate() {
 
         var interceptors = $httpProvider.interceptors;
 
+        function statusIsSuccessful(status){
+            return status >= 200 && status <= 299;
+        }
+
         function getInterceptor(interceptorExpression) {
             if (angular.isString(interceptorExpression)) {
                 return $injector.get(interceptorExpression);
@@ -82,11 +86,20 @@ function mockTemplate() {
             for (var i = interceptors.length - 1; i >= 0; i--) {
                 var interceptor = getInterceptor(interceptors[i]);
 
-                if (interceptor.response) {
+                if (interceptor.response &&
+                    (response.status === undefined || statusIsSuccessful(response.status))
+                ) {
                     $q.when(interceptor.response(response)).then(function(interceptedResponse){
                         response = interceptedResponse;
                     });
                 }
+
+                if (interceptor.responseError &&
+                    !(response.status === undefined || statusIsSuccessful(response.status))) {
+                    $q.reject(interceptor.responseError(response)).then(null, function(interceptedResponse){
+                        response = interceptedResponse;
+                    });
+                }
             }
 
             return response;
@@ -214,10 +227,6 @@ function mockTemplate() {
             return myPromise;
         }
 
-        function statusIsSuccessful(status){
-            return status >= 200 && status <= 299;
-        }
-
         function createHeaderGetterFunction(responseHeaders){
             return function(headerName) {
                 if (!headerName) {

tests/interceptors.test.js

@@ -60,6 +60,13 @@ describe('interceptors', function(){
 					}
 
 					return response;
+				},
+				responseError: function(response){
+					if(response.config.url.match(/response-error/)){
+						response.data.interceptedResponseError = true;
+					}
+
+					return $q.reject(response);
 				}
 			}
 		}]);
@@ -129,6 +136,17 @@ describe('interceptors', function(){
 		});
 	});
 
+	it('allows for intercepts handling an error response', function(done){
+		http({
+			method: 'GET',
+			url: 'test-url.com/response-error'
+		}).catch(function(response){
+			expect(response.data.interceptedResponseError).toBe(true);
+			expect(response.data.name).toBe('intercept test');
+			done();
+		});
+	});
+
 	it('provides default empty object headers if none are set', function(done){
 		http({
 			method: 'GET',

tests/setup.js

@@ -169,6 +169,19 @@
 				}
 			}
 		},
+		{
+			request: {
+				path: '/response-error',
+				interceptedRequest: true,
+				method: 'get'
+			},
+			response: {
+				data: {
+					name: 'intercept test'
+				},
+				status: 400
+			}
+		},
 		{
 			request: {
 				path: '/anonymous-intercept',