Merge pull request #118 from aternosorg/not-nullable-matches

Make members for matches not-nullable

Author: pavog

src/Analysis/Problem/Bukkit/AmbiguousPluginNameProblem.php

@@ -8,8 +8,8 @@
 
 class AmbiguousPluginNameProblem extends PluginProblem
 {
-    protected ?string $firstPluginPath = null;
-    protected ?string $secondPluginPath = null;
+    protected string $firstPluginPath;
+    protected string $secondPluginPath;
 
     /**
      * @inheritDoc

src/Analysis/Problem/Bukkit/PluginCommandExceptionProblem.php

@@ -9,7 +9,7 @@
 
 class PluginCommandExceptionProblem extends PluginProblem
 {
-    protected ?string $command = null;
+    protected string $command;
 
     /**
      * @inheritDoc

src/Analysis/Problem/Bukkit/PluginDependencyProblem.php

@@ -8,7 +8,7 @@
 
 class PluginDependencyProblem extends PluginFileProblem
 {
-    protected ?string $dependencyPluginName = null;
+    protected string $dependencyPluginName;
 
     /**
      * @return string|null

src/Analysis/Problem/Bukkit/PluginFileProblem.php

@@ -18,12 +18,12 @@
  */
 abstract class PluginFileProblem extends PluginProblem
 {
-    protected ?string $pluginFilePath = null;
+    protected string $pluginFilePath;
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getPluginFilePath(): ?string
+    public function getPluginFilePath(): string
     {
         return $this->pluginFilePath;
     }

src/Analysis/Problem/Bukkit/PluginProblem.php

@@ -20,12 +20,12 @@
  */
 abstract class PluginProblem extends BukkitProblem
 {
-    protected ?string $pluginName = null;
+    protected string $pluginName;
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getPluginName(): ?string
+    public function getPluginName(): string
     {
         return $this->pluginName;
     }

src/Analysis/Problem/Bukkit/UnsupportedApiVersionProblem.php

@@ -7,12 +7,12 @@
 
 class UnsupportedApiVersionProblem extends PluginFileProblem
 {
-    protected ?string $apiVersion = null;
+    protected string $apiVersion;
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getApiVersion(): ?string
+    public function getApiVersion(): string
     {
         return $this->apiVersion;
     }

src/Analysis/Problem/Bukkit/WorldDuplicateProblem.php

@@ -7,12 +7,12 @@
 
 class WorldDuplicateProblem extends BukkitProblem
 {
-    protected ?string $worldName = null;
+    protected string $worldName;
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getWorldName(): ?string
+    public function getWorldName(): string
     {
         return $this->worldName;
     }

src/Analysis/Problem/Fabric/FabricIncompatibleModsProblem.php

@@ -7,7 +7,7 @@
 
 class FabricIncompatibleModsProblem extends FabricModProblem
 {
-    protected ?string $secondModName = null;
+    protected string $secondModName;
 
     /**
      * @inheritDoc
@@ -21,9 +21,9 @@ public function getMessage(): string
     }
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getSecondModName(): ?string
+    public function getSecondModName(): string
     {
         return $this->secondModName;
     }

src/Analysis/Problem/Fabric/FabricModProblem.php

@@ -11,12 +11,12 @@ abstract class FabricModProblem extends FabricProblem
     protected static string $modNamePattern = "(?:'([^\']+)' \((?:[^\)]+)\)|([\w-]+))";
     protected static string $modIDPattern = "([^ ,]+)";
 
-    protected ?string $modName = null;
+    protected string $modName;
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getModName(): ?string
+    public function getModName(): string
     {
         return $this->modName;
     }

src/Analysis/Problem/Forge/ModDuplicateProblem.php

@@ -9,8 +9,8 @@
 
 class ModDuplicateProblem extends ModProblem
 {
-    protected ?string $firstModPath = null;
-    protected ?string $secondModPath = null;
+    protected string $firstModPath;
+    protected string $secondModPath;
 
     /**
      * @inheritDoc
@@ -67,17 +67,17 @@ public function isEqual(InsightInterface $insight): bool
     }
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getFirstModPath(): ?string
+    public function getFirstModPath(): string
     {
         return $this->firstModPath;
     }
 
     /**
-     * @return string|null
+     * @return string
      */
-    public function getSecondModPath(): ?string
+    public function getSecondModPath(): string
     {
         return $this->secondModPath;
     }