Merge pull request #4 from 007hacky007/txnrequest-fix

Removed extra unused parameter $key from the txnRequest method

Author: matthi4s

src/Client.php

@@ -204,7 +204,7 @@ public function putIf(string $key, string $value, $compareValue, bool $returnNew
         $compare = $this->getCompareForIf($key, $compareValue);
         $failOperation = $this->getFailOperation($key, $returnNewValueOnFail);
 
-        $response = $this->txnRequest($key, [$operation], $failOperation, [$compare]);
+        $response = $this->txnRequest([$operation], $failOperation, [$compare]);
         return $this->getIfResponse($returnNewValueOnFail, $response);
     }
 
@@ -224,7 +224,7 @@ public function deleteIf(string $key, $compareValue, bool $returnNewValueOnFail
         $compare = $this->getCompareForIf($key, $compareValue);
         $failOperation = $this->getFailOperation($key, $returnNewValueOnFail);
 
-        $response = $this->txnRequest($key, [$operation], $failOperation, [$compare]);
+        $response = $this->txnRequest([$operation], $failOperation, [$compare]);
         return $this->getIfResponse($returnNewValueOnFail, $response);
     }
 
@@ -291,16 +291,15 @@ public function refreshLease(int $leaseID)
     }
 
     /**
-     * Execute $requestOperation if $key value matches $previous otherwise $returnNewValueOnFail
+     * Execute $requestOperations if Compare succeeds, execute $failureOperations otherwise if defined
      *
-     * @param string $key
      * @param array $requestOperations operations to perform on success, array of RequestOp objects
      * @param array|null $failureOperations operations to perform on failure, array of RequestOp objects
      * @param array $compare array of Compare objects
      * @return TxnResponse
      * @throws InvalidResponseStatusCodeException
      */
-    public function txnRequest(string $key, array $requestOperations, ?array $failureOperations, array $compare): TxnResponse
+    public function txnRequest(array $requestOperations, ?array $failureOperations, array $compare): TxnResponse
     {
         $client = $this->getKvClient();
 

src/ClientInterface.php

@@ -78,16 +78,15 @@ public function putIf(string $key, string $value, $compareValue, bool $returnNew
     public function deleteIf(string $key, $compareValue, bool $returnNewValueOnFail = false);
 
     /**
-     * Execute $requestOperation if $key value matches $previous otherwise $returnNewValueOnFail
+     * Execute $requestOperations if Compare succeeds, execute $failureOperations otherwise if defined
      *
-     * @param string $key
      * @param array $requestOperations operations to perform on success, array of RequestOp objects
      * @param array|null $failureOperations operations to perform on failure, array of RequestOp objects
      * @param array $compare array of Compare objects
      * @return TxnResponse
      * @throws InvalidResponseStatusCodeException
      */
-    public function txnRequest(string $key, array $requestOperations, ?array $failureOperations, array $compare): TxnResponse;
+    public function txnRequest(array $requestOperations, ?array $failureOperations, array $compare): TxnResponse;
 
     /**
      * Get an instance of Compare

src/ShardedClient.php

@@ -145,9 +145,9 @@ public function deleteIf(string $key, $compareValue, bool $returnNewValueOnFail
      * @inheritDoc
      * @throws Exception
      */
-    public function txnRequest(string $key, array $requestOperations, ?array $failureOperations, array $compare): TxnResponse
+    public function txnRequest(array $requestOperations, ?array $failureOperations, array $compare): TxnResponse
     {
-        return $this->getClientFromKey($key)->txnRequest($key, $requestOperations, $failureOperations, $compare);
+        return $this->getRandomClient()->txnRequest($requestOperations, $failureOperations, $compare);
     }
 
     /**