Merge pull request #3033 from athenianco/reviews-cfg

[DEV-5362] Add the review action rules

Author: vmarkovtsev

.github/request-review-rules.yml

@@ -0,0 +1,49 @@
+"**.pyx":
+- team: api-admin
+"**.pyd":
+- team: api-admin
+"**.h":
+- team: api-admin
+
+"server/athenian/api/internal/features/**":
+- team: api-admin
+"server/athenian/api/internal/miners/**":
+- team: api-admin
+"server/athenian/api/internal/prefixer.py":
+- team: api-admin
+
+"server/athenian/api/models/metadata/**":
+- team: api-admin
+"server/athenian/api/models/precomputed/**":
+- team: api-admin
+"server/athenian/api/models/persistentdata/**":
+- team: api-admin
+
+"server/athenian/api/async_utils.py":
+- team: api-admin
+"server/athenian/api/auth.py":
+- team: api-admin
+"server/athenian/api/cache.py":
+- team: api-admin
+"server/athenian/api/defer.py":
+- team: api-admin
+"server/athenian/api/faster_pandas.py":
+- team: api-admin
+"server/athenian/api/int_to_str.py":
+- team: api-admin
+"server/athenian/api/serialization.py":
+- team: api-admin
+"server/athenian/api/tracing.py":
+- team: api-admin
+"server/athenian/api/typing_utils.py":
+- team: api-admin
+"Dockerfile":
+- team: api-admin
+"pyproject.toml":
+- team: api-admin
+"requirements.txt":
+- team: api-admin
+"setup.py":
+- team: api-admin
+".github/**":
+- team: api-admin

.github/require-review-rules.yml

@@ -0,0 +1,39 @@
+- name: Native
+  paths:
+  - "**.pyx"
+  - "**.pyd"
+  - "**.h"
+  teams:
+  - api-admin
+- name: Guts
+  paths:
+  - "server/athenian/api/internal/features/**"
+  - "server/athenian/api/internal/miners/**"
+  - "server/athenian/api/internal/prefixer.py"
+  teams:
+  - api-admin
+- name: DB
+  paths:
+  - "server/athenian/api/models/metadata/**"
+  - "server/athenian/api/models/precomputed/**"
+  - "server/athenian/api/models/persistentdata/**"
+  teams:
+  - api-admin
+- name: Engine
+  paths:
+  - "server/athenian/api/async_utils.py"
+  - "server/athenian/api/auth.py"
+  - "server/athenian/api/cache.py"
+  - "server/athenian/api/defer.py"
+  - "server/athenian/api/faster_pandas.py"
+  - "server/athenian/api/int_to_str.py"
+  - "server/athenian/api/serialization.py"
+  - "server/athenian/api/tracing.py"
+  - "server/athenian/api/typing_utils.py"
+  - "Dockerfile"
+  - "pyproject.toml"
+  - "requirements.txt"
+  - "setup.py"
+  - ".github/**"
+  teams:
+  - api-admin

.github/workflows/reviews.yml

@@ -0,0 +1,33 @@
+name: 👤 Review
+
+on:
+  pull_request:
+  pull_request_review:
+
+jobs:
+  require_reviewer:
+    name: require
+    runs-on: ubuntu-latest
+    steps:
+    - name: actions/checkout
+      uses: actions/checkout@v3
+      with:
+        submodules: false
+    - uses: Automattic/action-required-review@v3
+      with:
+        requirements-file: .github/require-review-rules.yml
+        status: Review by athenianco/api-admin is required
+        fail: true
+        token: ${{ secrets.GKWILLIE_REVIEW_TOKEN }}
+  assign_reviewer:
+    name: request
+    runs-on: ubuntu-latest
+    steps:
+    - name: actions/checkout
+      uses: actions/checkout@v3
+      with:
+        submodules: false
+    - uses: shufo/[email protected]
+      with:
+        config: .github/request-review-rules.yml
+        token: ${{ secrets.GKWILLIE_REVIEW_TOKEN }}

server/athenian/api/internal/features/github/pull_request_metrics.py

@@ -320,7 +320,7 @@ def _analyze(
     ) -> np.ndarray:
         result = np.full((len(min_times), len(facts)), self.nan, self.dtype)
         merge_end = result.copy().astype(min_times.dtype)
-        closed_indexes = np.nonzero(facts[PullRequestFacts.f.merged].notnull().values)[0]
+        closed_indexes = np.flatnonzero(facts[PullRequestFacts.f.merged].notnull().values)
         closed = facts[PullRequestFacts.f.merged].values[closed_indexes]
         closed_in_range = (min_times[:, None] <= closed) & (closed < max_times[:, None])
         closed_indexes = np.broadcast_to(