Merge pull request #2299 from shanberg/reuse-comments-toast

Reuse comments toast

Author: jefftangx

src/js/components/AppToolbar/AppToolbar.tsx

@@ -36,6 +36,7 @@ import { LayoutContext, layoutAnimationProps, layoutAnimationTransition } from "
 import { FakeTrafficLights } from './components/FakeTrafficLights';
 import { WindowButtons } from './components/WindowButtons';
 import { LocationIndicator } from './components/LocationIndicator';
+import { reusableToast } from '@/utils/reusableToast';
 
 const PAGE_TITLE_SHOW_HEIGHT = 24;
 
@@ -187,6 +188,7 @@ export const AppToolbar = (props: AppToolbarProps): React.ReactElement => {
   const [isScrolledPastTitle, setIsScrolledPastTitle] = React.useState(null);
 
   const toast = useToast();
+  const commentsToggleToastRef = React.useRef(null);
 
   // add event listener to detect when the user scrolls past the title
   React.useLayoutEffect(() => {
@@ -226,7 +228,7 @@ export const AppToolbar = (props: AppToolbarProps): React.ReactElement => {
       onClick: () => {
         if (isShowComments) {
           handleClickComments();
-          toast({
+          reusableToast(toast, commentsToggleToastRef, {
             title: "Comments hidden",
             status: "info",
             duration: 5000,
@@ -235,9 +237,8 @@ export const AppToolbar = (props: AppToolbarProps): React.ReactElement => {
 
         } else {
           handleClickComments();
-          toast({
+          reusableToast(toast, commentsToggleToastRef, {
             title: "Comments shown",
-            status: "info",
             duration: 5000,
             position: "top-right"
           });

src/js/components/utils/reusableToast.ts

@@ -0,0 +1,25 @@
+/**
+ * Creates or updates a toast message with the given options.
+ * @param toast The toast function
+ * @param ref The ref to store the toast
+ * @param props 
+ */
+export const reusableToast = (toast, ref, props) => {
+  if (ref.current) {
+    toast.update(ref.current, {
+      ...props,
+      onCloseComplete: () => {
+        props.onCloseComplete && props.onCloseComplete();
+        ref.current = null;
+      }
+    });
+  } else {
+    ref.current = toast({
+      ...props,
+      onCloseComplete: () => {
+        props.onCloseComplete && props.onCloseComplete();
+        ref.current = null;
+      }
+    });
+  }
+}