pwsh\Init-App.ps1 - RemoveFromEnvPath

atiq-cs · atiq-cs · commit ce39b2d6925a · 2025-10-04T19:53:46.000-07:00
- critical bug fix, reaffirms that soem code review is required in this code
base
diff --git a/pwsh/Init-App.ps1 b/pwsh/Init-App.ps1
@@ -66,7 +66,7 @@ function AddKTAppToEnv([string] $App = '', [string] $PFilesX64PTDir = '', [strin
 }
 
 function RemoveFromEnvPath([string] $path = '') {
-  if (-not [string]::IsNullOrEmpty($path)) {
+  if ([string]::IsNullOrEmpty($path)) {
     Write-Host "Empty string: $path"
     return
   }
@@ -131,7 +131,6 @@ function InitVariables([string] $InitType = 'resetEnvPath') {
           '\Microsoft\WindowsApps;C:\windows\System32\WindowsPowerShell\v1.0;' + $ShellHome + ';' +
            $PSHOME + ';' + 'C:\WINDOWS\System32\OpenSSH\'
 
-
         # TODO: iterate over a list instead
         #  check if Linus uses DOTNET_ROOT after installing dotnet
         if (Test-Path Env:DOTNET_ROOT) { Remove-Item Env:DOTNET_ROOT }

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ function AddKTAppToEnv([string] $App = '', [string] $PFilesX64PTDir = '', [strin`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`function RemoveFromEnvPath([string] $path = '') {`
`69`		`- if (-not [string]::IsNullOrEmpty($path)) {`
	`69`	`+ if ([string]::IsNullOrEmpty($path)) {`
`70`	`70`	`Write-Host "Empty string: $path"`
`71`	`71`	`return`
`72`	`72`	`}`
`@@ -131,7 +131,6 @@ function InitVariables([string] $InitType = 'resetEnvPath') {`
`131`	`131`	`'\Microsoft\WindowsApps;C:\windows\System32\WindowsPowerShell\v1.0;' + $ShellHome + ';' +`
`132`	`132`	`$PSHOME + ';' + 'C:\WINDOWS\System32\OpenSSH\'`
`133`	`133`
`134`		`-`
`135`	`134`	`# TODO: iterate over a list instead`
`136`	`135`	`# check if Linus uses DOTNET_ROOT after installing dotnet`
`137`	`136`	`if (Test-Path Env:DOTNET_ROOT) { Remove-Item Env:DOTNET_ROOT }`