Replace $_GET/$_POST/$_FILES with App::getRequestXxx() (#2101)

Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>

Author: abbadon1334

demos/_includes/ReloadTest.php

@@ -17,7 +17,7 @@ protected function init(): void
         $label = Label::addTo($this, ['Testing...', 'detail' => '', 'class.red' => true]);
         $reload = new JsReload($this, [$this->name => 'ok']);
 
-        if (isset($_GET[$this->name])) {
+        if ($this->getApp()->hasRequestQueryParam($this->name)) {
             $label->class[] = 'green';
             $label->content = 'Reload success';
         } else {

demos/_includes/ViewTester.php

@@ -22,7 +22,7 @@ protected function init(): void
         $label = Label::addTo($this, ['CallBack', 'detail' => 'fail', 'class.red' => true]);
         $reload = new JsReload($this, [$this->name => 'ok']);
 
-        if (isset($_GET[$this->name])) {
+        if ($this->getApp()->hasRequestQueryParam($this->name)) {
             $label->class[] = 'green';
             $label->detail = 'success';
         } else {

demos/_unit-test/callback-nested.php

@@ -28,7 +28,7 @@
 $loader->set(static function (Loader $p) use ($m) {
     Header::addTo($p, ['Loader-1', 'size' => 4]);
 
-    if (isset($_GET['err_main_loader'])) {
+    if ($p->getApp()->hasRequestQueryParam('err_main_loader')) {
         throw new Exception('Exception from Main Loader');
     }
 
@@ -39,9 +39,9 @@
     $loaderSub->set(static function (Loader $p) use ($m) {
         Header::addTo($p, ['Loader-2', 'size' => 4]);
 
-        if (isset($_GET['err_sub_loader'])) {
+        if ($p->getApp()->hasRequestQueryParam('err_sub_loader')) {
             throw new Exception('Exception from Sub Loader');
-        } elseif (isset($_GET['err_sub_loader2'])) {
+        } elseif ($p->getApp()->hasRequestQueryParam('err_sub_loader2')) {
             throw new \Error('Exception II from Sub Loader');
         }
 

demos/_unit-test/stream.php

@@ -128,7 +128,7 @@ public function getMetadata($key = null)
     }
 });
 
-$sizeBytes = $_GET['size_mb'] * 1024 * 1024;
+$sizeBytes = (int) $app->getRequestQueryParam('size_mb') * 1024 * 1024;
 
 $stream = new $hugePseudoStreamClass(static function (int $pos) {
     return "\n\0" . str_repeat($pos . ',', 1024);

demos/basic/label.php

@@ -29,7 +29,7 @@
 $del = Label::addTo($app, ['Zoe', 'image' => 'https://fomantic-ui.com/images/avatar/small/ade.jpg', 'iconRight' => 'delete']);
 $del->on('click', '.delete', $del->js()->fadeOut());
 
-$val = isset($_GET['toggle']) && $_GET['toggle'];
+$val = $app->hasRequestQueryParam('toggle') && $app->getRequestQueryParam('toggle');
 $toggle = Label::addTo($app, ['icon' => 'toggle ' . ($val ? 'on' : 'off')])->set('Value: ' . $val);
 $toggle->on('click', new JsReload($toggle, ['toggle' => $val ? null : 1]));
 

demos/collection/multitable.php

@@ -32,7 +32,7 @@ public function setModel(Model $model, array $route = []): void
         $table = Table::addTo($this->addColumn(), ['header' => false, 'class.very basic selectable' => true])->setStyle('cursor', 'pointer');
         $table->setModel($model, [$model->titleField]);
 
-        $selections = explode(',', $_GET[$this->name] ?? '');
+        $selections = explode(',', $this->getApp()->tryGetRequestQueryParam($this->name) ?? '');
 
         if ($selections[0]) {
             $table->js(true)->find('tr[data-id=' . $selections[0] . ']')->addClass('active');

demos/collection/table.php

@@ -14,7 +14,7 @@
 /** @var \Atk4\Ui\App $app */
 require_once __DIR__ . '/../init-app.php';
 
-if ($_GET['id'] ?? null) {
+if ($app->tryGetRequestQueryParam('id')) {
     $app->layout->js(true, new JsToast('Details link is in simulation mode.'));
 }
 

demos/form/form3.php

@@ -29,7 +29,7 @@
     ->on('click', new JsReload($seg, ['m' => 'stat']));
 
 $form = Form::addTo($seg, ['layout' => [Form\Layout\Columns::class]]);
-$modelClass = ['country' => Country::class, 'file' => File::class][$_GET['m'] ?? ''] ?? Stat::class;
+$modelClass = ['country' => Country::class, 'file' => File::class][$app->tryGetRequestQueryParam('m')] ?? Stat::class;
 $form->setModel((new $modelClass($app->db))->loadAny());
 
 $form->onSubmit(static function (Form $form) {

demos/init-app.php

@@ -31,6 +31,23 @@
 ]);
 $app->title = 'Agile UI Demo v' . $app->version;
 
+unset($_SERVER);
+unset($_GET);
+unset($_POST);
+unset($_FILES);
+if (isset($_COOKIE)) { // @phpstan-ignore-line https://github.com/phpstan/phpstan/issues/9953
+    $sessionCookieName = function_exists('session_name') ? session_name() : false;
+    foreach (array_keys($_COOKIE) as $k) {
+        if ($k !== $sessionCookieName) {
+            unset($_COOKIE[$k]);
+        }
+    }
+    if ($_COOKIE === []) {
+        unset($_COOKIE);
+    }
+}
+unset($_SESSION);
+
 if ($app->callExit !== true) {
     $app->stickyGet('APP_CALL_EXIT');
 }
@@ -85,7 +102,7 @@ public static function get_class(\Closure $createAnonymousClassFx): string
 $demosUrl = $rootUrl . 'demos/';
 
 // allow custom layout override
-$app->initLayout([!isset($_GET['layout']) ? Layout\Maestro::class : $app->stickyGet('layout')]);
+$app->initLayout([!$app->hasRequestQueryParam('layout') ? Layout\Maestro::class : $app->stickyGet('layout')]);
 
 $layout = $app->layout;
 if ($layout instanceof Layout\NavigableInterface) {

demos/interactive/jssortable.php

@@ -36,8 +36,8 @@
 
 $sortable = JsSortable::addTo($view, ['container' => 'ul', 'draggable' => 'li', 'dataLabel' => 'name']);
 
-$sortable->onReorder(static function (array $order, string $src, int $pos, int $oldPos) {
-    if ($_GET['btn'] ?? null) {
+$sortable->onReorder(static function (array $order, string $src, int $pos, int $oldPos) use ($app) {
+    if ($app->tryGetRequestQueryParam('btn')) {
         return new JsToast(implode(' - ', $order));
     }