0.31.1

Author: atkAudioUser

buildspec.json

@@ -47,6 +47,6 @@
   "uuids": {
     "windowsApp": "ad885c58-5ca9-44de-8f4f-1c12676626a9"
   },
-  "version": "0.31.0",
+  "version": "0.31.1",
   "website": "https://www.atkaudio.com"
 }

cmake/windows/compilerconfig.cmake

@@ -39,10 +39,6 @@ add_compile_options(
   "$<$<COMPILE_LANG_AND_ID:CXX,MSVC>:${_obs_msvc_cpp_options}>"
   "$<$<COMPILE_LANG_AND_ID:C,Clang>:${_obs_clang_c_options}>"
   "$<$<COMPILE_LANG_AND_ID:CXX,Clang>:${_obs_clang_cxx_options}>"
-  $<$<CONFIG:Release>:/Gy>
-  $<$<CONFIG:Release>:/GL>
-  $<$<CONFIG:Release>:/Oi>
-  $<$<CONFIG:RelWithDebInfo>:/Od>  # Disable optimizations for RelWithDebInfo
 )
 
 add_compile_definitions(
@@ -56,11 +52,6 @@ add_compile_definitions(
 )
 
 add_link_options(
-  $<$<CONFIG:Release>:/OPT:REF>
-  $<$<CONFIG:Release>:/OPT:ICF>
-  $<$<CONFIG:Release>:/LTCG>
-  $<$<CONFIG:Release>:/INCREMENTAL:NO>
-  $<$<CONFIG:RelWithDebInfo>:/INCREMENTAL>  # Enable incremental linking for RelWithDebInfo
   /DEBUG
   /Brepro
 )

lib/atkaudio/CMakeLists.txt

@@ -50,6 +50,7 @@ target_compile_definitions(
     JUCE_USE_CURL=1
     JUCE_WEB_BROWSER=0
     JUCE_MODAL_LOOPS_PERMITTED=1 # we use QT event loop, so this is needed
+    JUCE_DIRECT2D=0 # Disable Direct2D to avoid crash in applySingleChannelBoxBlurEffectInArea
     # Disable DBG() output in CI/GitHub Actions RelWithDebInfo builds (keeps debug symbols but no console spam in CI)
     $<$<AND:$<CONFIG:RelWithDebInfo>,$<OR:$<BOOL:$ENV{CI}>,$<BOOL:$ENV{GITHUB_ACTIONS}>>>:JUCE_DISABLE_ASSERTIONS>
 )

lib/atkaudio/cmake/cpack.cmake

@@ -6,6 +6,73 @@ string(JSON WEBSITE GET "${_buildspec_json}" website)
 string(JSON DISPLAYNAME GET "${_buildspec_json}" displayName)
 string(JSON PATHNAME GET "${_buildspec_json}" name)
 
+# Define ATK_CI_BUILD for CI builds
+if(DEFINED ENV{CI} OR DEFINED ENV{GITHUB_ACTIONS})
+  add_compile_definitions(ATK_CI_BUILD)
+endif()
+
+# Define ATK_DEBUG for Debug/RelWithDebInfo builds when not in CI
+if((CMAKE_BUILD_TYPE STREQUAL "Debug" OR CMAKE_BUILD_TYPE STREQUAL "RelWithDebInfo") AND NOT DEFINED ENV{CI} AND NOT DEFINED ENV{GITHUB_ACTIONS})
+  add_compile_definitions(ATK_DEBUG)
+endif()
+
+# Match JUCE's recommended config flags for Release and RelWithDebInfo
+if(UNIX)
+  # Fast math for all builds
+  string(APPEND CMAKE_C_FLAGS " -ffast-math")
+  string(APPEND CMAKE_CXX_FLAGS " -ffast-math")
+  
+  string(APPEND CMAKE_C_FLAGS_RELEASE " -g -O3")
+  string(APPEND CMAKE_CXX_FLAGS_RELEASE " -g -O3")
+  string(APPEND CMAKE_C_FLAGS_RELWITHDEBINFO " -g -O3")
+  string(APPEND CMAKE_CXX_FLAGS_RELWITHDEBINFO " -g -O3")
+  
+  if(APPLE)
+    string(APPEND CMAKE_OBJC_FLAGS " -ffast-math")
+    string(APPEND CMAKE_OBJCXX_FLAGS " -ffast-math")
+    string(APPEND CMAKE_OBJC_FLAGS_RELEASE " -g -O3")
+    string(APPEND CMAKE_OBJCXX_FLAGS_RELEASE " -g -O3")
+    string(APPEND CMAKE_OBJC_FLAGS_RELWITHDEBINFO " -g -O3")
+    string(APPEND CMAKE_OBJCXX_FLAGS_RELWITHDEBINFO " -g -O3")
+  endif()
+  
+  # LTO flags (match juce_recommended_lto_flags) - only on CI for faster local builds
+  if(DEFINED ENV{CI} OR DEFINED ENV{GITHUB_ACTIONS})
+    add_compile_options($<$<CONFIG:Release>:-flto>)
+    add_link_options($<$<CONFIG:Release>:-flto>)
+    add_compile_options($<$<CONFIG:RelWithDebInfo>:-flto>)
+    add_link_options($<$<CONFIG:RelWithDebInfo>:-flto>)
+  endif()
+  
+elseif(WIN32)
+  # Fast math for all builds
+  add_compile_options(/fp:fast)
+  
+  # Match JUCE: /Ox for Release, /Zi for debug symbols
+  add_compile_options(
+    $<$<CONFIG:Release>:/Zi>
+    $<$<CONFIG:Release>:/Ox>
+    $<$<CONFIG:Release>:/MP>
+    $<$<CONFIG:RelWithDebInfo>:/Zi>
+    $<$<CONFIG:RelWithDebInfo>:/Ox>
+    $<$<CONFIG:RelWithDebInfo>:/MP>
+  )
+  
+  # LTO flags (match juce_recommended_lto_flags) - only on CI for faster local builds
+  if(DEFINED ENV{CI} OR DEFINED ENV{GITHUB_ACTIONS})
+    if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
+      add_compile_options($<$<CONFIG:Release>:/GL>)
+      add_link_options($<$<CONFIG:Release>:/LTCG>)
+      add_compile_options($<$<CONFIG:RelWithDebInfo>:/GL>)
+      add_link_options($<$<CONFIG:RelWithDebInfo>:/LTCG>)
+    else()
+      # Clang-cl
+      add_compile_options($<$<CONFIG:Release>:-flto>)
+      add_compile_options($<$<CONFIG:RelWithDebInfo>:-flto>)
+    endif()
+  endif()
+endif()
+
 file(CREATE_LINK "${CMAKE_CURRENT_SOURCE_DIR}/README.md" "${CMAKE_BINARY_DIR}/README.txt" SYMBOLIC)
 set(CPACK_RESOURCE_FILE_README "${CMAKE_BINARY_DIR}/README.txt")
 
@@ -21,10 +88,21 @@ else()
   set(CPACK_PACKAGE_NAME "${DISPLAYNAME}")
 endif()
 
+# Detect Windows target architecture once for all subsequent checks
+if(WIN32)
+  if(CMAKE_GENERATOR_PLATFORM)
+    set(_win_target_arch "${CMAKE_GENERATOR_PLATFORM}")
+  elseif(CMAKE_VS_PLATFORM_NAME)
+    set(_win_target_arch "${CMAKE_VS_PLATFORM_NAME}")
+  else()
+    set(_win_target_arch "${CMAKE_SYSTEM_PROCESSOR}")
+  endif()
+endif()
+
 # Include architecture in package name only for Windows ARM64
 # Include build type in filename for local builds (non-CI)
 if(WIN32)
-  if(CMAKE_VS_PLATFORM_NAME STREQUAL "ARM64")
+  if(_win_target_arch STREQUAL "ARM64")
     set(CPACK_PACKAGE_FILE_NAME ${PATHNAME}-${PROJECT_VERSION}-${CMAKE_SYSTEM_NAME}-arm64)
   else()
     # Windows x64 - no architecture suffix
@@ -73,7 +151,13 @@ if(WIN32)
     LIBRARY DESTINATION "${TARGET_NAME}/bin/64bit"
     COMPONENT plugin)
 
-  # Note: PDB files are packaged separately in GitHub Actions workflow
+  # Include PDB files for debugging (x64 only, not ARM64)
+  if(NOT _win_target_arch STREQUAL "ARM64")
+    install(FILES $<TARGET_PDB_FILE:${TARGET_NAME}> 
+      DESTINATION "${TARGET_NAME}/bin/64bit" 
+      COMPONENT plugin 
+      OPTIONAL)
+  endif()
 
   # Windows data install pattern
   if(EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/data")
@@ -229,7 +313,7 @@ if(WIN32)
   set(CPACK_PACKAGE_EXTENSION "exe")
 
   # Configure NSIS for specific architectures
-  if(CMAKE_VS_PLATFORM_NAME STREQUAL "ARM64")
+  if(_win_target_arch STREQUAL "ARM64")
     # Simple architecture check for ARM64 installer
     set(CPACK_NSIS_EXTRA_PREINSTALL_COMMANDS "
       ; Simple architecture check for ARM64
@@ -314,7 +398,7 @@ include(CPack)
 
 # Determine debug symbols package name based on platform
 if(WIN32)
-  if(CMAKE_VS_PLATFORM_NAME STREQUAL "ARM64")
+  if(_win_target_arch STREQUAL "ARM64")
     set(DEBUG_ARCH "arm64")
   else()
     set(DEBUG_ARCH "x64")
@@ -428,7 +512,7 @@ if(APPLE)
   set(PORTABLE_OS_NAME "macos")
 endif()
 set(CPACK_PACKAGE_FILE_NAME "portable-${PATHNAME}-${PROJECT_VERSION}-${PORTABLE_OS_NAME}")
-if(WIN32 AND CMAKE_VS_PLATFORM_NAME STREQUAL "ARM64")
+if(WIN32 AND _win_target_arch STREQUAL "ARM64")
   set(CPACK_PACKAGE_FILE_NAME "portable-${PATHNAME}-${PROJECT_VERSION}-${PORTABLE_OS_NAME}-arm64")
 endif()
 if(UNIX AND NOT APPLE)

lib/atkaudio/src/atkaudio/AudioProcessorGraphMT/AudioProcessorGraphMT.cpp

@@ -1297,7 +1297,7 @@ class RenderSequenceBuilder
             const auto nodeID = node->nodeID;
 
             // Skip I/O nodes - we handle input/output externally in perform()
-            if (auto* ioNode = dynamic_cast<AudioProcessorGraphMT::AudioGraphIOProcessor*>(node->getProcessor()))
+            if (dynamic_cast<AudioProcessorGraphMT::AudioGraphIOProcessor*>(node->getProcessor()))
                 continue;
 
             // Skip nodes not in filter (if filter is provided)
@@ -1765,14 +1765,19 @@ class RenderSequenceBuilder
         DBG("[LATENCY] Building filtered sequence for " << orderedNodes.size() << " nodes");
         for (auto* node : orderedNodes)
         {
+            (void)node; // Used in DBG macros only
             DBG("[LATENCY]   Node in subgraph: "
                 << node->getProcessor()->getName()
                 << " (nodeID="
                 << (int)node->nodeID.uid
                 << ")");
         }
         for (const auto& [nodeId, delay] : globalDelays)
+        {
+            (void)nodeId;
+            (void)delay; // Used in DBG macros only
             DBG("[LATENCY]   GlobalDelay: nodeID=" << (int)nodeId << " delay=" << delay);
+        }
 
         int maxChannelsNeeded = 0;
         int maxMidiBuffersNeeded = 1; // At least one MIDI buffer
@@ -2216,7 +2221,7 @@ class ParallelRenderSequence
             for (int i = 0; i < numSamples; ++i)
             {
                 delayLine.pushSample(channel, src[i]);
-                float delayedSample = delayLine.popSample(channel, delay);
+                float delayedSample = delayLine.popSample(channel, static_cast<float>(delay));
                 dst[i] += delayedSample;
             }
         }
@@ -2859,6 +2864,7 @@ class ParallelRenderSequence
         const std::shared_ptr<ChainBufferPool::PooledBuffer>& savedInputBuffer
     )
     {
+        (void)audio; // Unused in current implementation
         for (auto& obsNode : obsOutputNodes)
         {
             auto& nodeBuffer = obsNode.buffer->audioBuffer;
@@ -3290,12 +3296,14 @@ class ParallelRenderSequence
 
             if (currentLatencySum != chain->latencySum)
             {
+#ifdef ATK_DEBUG
                 DBG("[PARALLEL] Latency changed in subgraph "
                     << i
                     << ": expected "
                     << chain->latencySum
                     << ", current "
                     << currentLatencySum);
+#endif
                 return true;
             }
         }
@@ -3873,8 +3881,10 @@ void AudioProcessorGraphMT::setStateInformation(const void*, int)
 
 void AudioProcessorGraphMT::processBlock(AudioBuffer<float>& audio, MidiBuffer& midi)
 {
+#ifdef ATK_DEBUG
     if (!midi.isEmpty())
         DBG("[AudioProcessorGraphMT::processBlock] Received MIDI: " << midi.getNumEvents() << " events");
+#endif
 
     return pimpl->processBlock(audio, midi, getPlayHead());
 }

lib/atkaudio/src/atkaudio/AudioProcessorGraphMT/AudioThreadPool.h

@@ -270,6 +270,7 @@ class AudioThreadPool
 
     void initialize(int numWorkers = 0, int priority = 8)
     {
+        (void)priority; // Unused - reserved for future use
         std::lock_guard<std::mutex> lock(poolMutex);
 
         if (isInitialized)

lib/atkaudio/src/atkaudio/DeviceIo/DeviceIo.cpp

@@ -88,7 +88,7 @@ struct atk::DeviceIo::Impl : public juce::Timer
             // No hardware input: send OBS input to hardware output
             hardwareOutputBuffer.setSize(numChannels, numSamples, false, false, true);
             for (int ch = 0; ch < numChannels; ++ch)
-                std::memcpy(hardwareOutputBuffer.getWritePointer(ch), buffer[ch], numSamples * sizeof(float));
+                std::copy(buffer[ch], buffer[ch] + numSamples, hardwareOutputBuffer.getWritePointer(ch));
             // Apply output delay before sending to hardware
             applyOutputDelay(hardwareOutputBuffer, numChannels, numSamples, sampleRate);
             fromObsBuffer.write(hardwareOutputBuffer.getArrayOfWritePointers(), numChannels, numSamples, sampleRate);
@@ -113,7 +113,7 @@ struct atk::DeviceIo::Impl : public juce::Timer
             {
                 // Replace: HW input -> OBS output
                 for (int ch = 0; ch < numChannels; ++ch)
-                    std::memcpy(buffer[ch], tempBuffer.getReadPointer(ch), numSamples * sizeof(float));
+                    std::copy(tempBuffer.getReadPointer(ch), tempBuffer.getReadPointer(ch) + numSamples, buffer[ch]);
             }
         }
         // else: No hardware input - pass through OBS audio unchanged