Skip to content

Commit 12d7294

Browse files
committed
APP-7318: Make FS usage in get_by_*() methods consistent with GET API (return active and archive assets)
1 parent 935becb commit 12d7294

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

pyatlan/client/asset.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,6 @@ def get_by_qualified_name(
440440
):
441441
search = (
442442
FluentSearch()
443-
.select()
444443
.where(Asset.QUALIFIED_NAME.eq(qualified_name))
445444
.where(Asset.TYPE_NAME.eq(asset_type.__name__))
446445
)
@@ -514,7 +513,6 @@ def get_by_guid(
514513
):
515514
search = (
516515
FluentSearch()
517-
.select()
518516
.where(Asset.GUID.eq(guid))
519517
.where(Asset.TYPE_NAME.eq(asset_type.__name__))
520518
)

tests/integration/api_asset_test.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -401,8 +401,10 @@ def test_delete_api_object(
401401
def test_read_deleted_api_object(
402402
client: AtlanClient, connection: Connection, api_object_overload: APIObject
403403
):
404-
deleted = client.asset.get_by_guid(
405-
api_object_overload.guid, asset_type=APIObject, ignore_relationships=False
404+
# Running get_by_qualified_name with attributes to use FluentSearch behind the scenes
405+
assert api_object_overload.qualified_name
406+
deleted = client.asset.get_by_qualified_name(
407+
api_object_overload.qualified_name, asset_type=APIObject, attributes=["name"]
406408
)
407409
assert deleted
408410
assert deleted.guid == api_object_overload.guid
@@ -639,8 +641,9 @@ def test_delete_api_query(
639641
def test_read_deleted_api_query(
640642
client: AtlanClient, connection: Connection, api_query_overload_3: APIQuery
641643
):
644+
# Running get_by_guid with attributes to use FluentSearch behind the scenes
642645
deleted = client.asset.get_by_guid(
643-
api_query_overload_3.guid, asset_type=APIQuery, ignore_relationships=False
646+
api_query_overload_3.guid, asset_type=APIQuery, attributes=["name"]
644647
)
645648
assert deleted
646649
assert deleted.guid == api_query_overload_3.guid

0 commit comments

Comments
 (0)