Fixing the get_all() method of user and group

Author: vaibhavatlan

pyatlan/client/group.py

@@ -142,7 +142,7 @@ def get_all(
         offset: int = 0,
         sort: Optional[str] = "name",
         columns: Optional[List[str]] = None,
-    ) -> List[AtlanGroup]:
+    ) -> GroupResponse:
         """
         Retrieve all groups defined in Atlan.
 
@@ -152,9 +152,10 @@ def get_all(
         :param columns: provides columns projection support for groups endpoint
         :returns: a list of all the groups in Atlan
         """
-        if response := self.get(offset=offset, limit=limit, sort=sort, columns=columns):
-            return response.records  # type: ignore
-        return None  # type: ignore
+        response: GroupResponse = self.get(
+            offset=offset, limit=limit, sort=sort, columns=columns
+        )
+        return response  # type: ignore
 
     @validate_arguments
     def get_by_name(

pyatlan/client/user.py

@@ -201,7 +201,7 @@ def get_all(
         limit: int = 20,
         offset: int = 0,
         sort: Optional[str] = "username",
-    ) -> List[AtlanUser]:
+    ) -> UserResponse:
         """
         Retrieve all users defined in Atlan.
 
@@ -210,9 +210,8 @@ def get_all(
         :param sort: property by which to sort the results, by default : `username`
         :returns: a list of all the users in Atlan
         """
-        if response := self.get(offset=offset, limit=limit, sort=sort):
-            return response.records  # type: ignore
-        return None  # type: ignore
+        response: UserResponse = self.get(offset=offset, limit=limit, sort=sort)
+        return response
 
     @validate_arguments
     def get_by_email(

testing.py

@@ -0,0 +1,7 @@
+from pyatlan.client.atlan import AtlanClient
+
+client = AtlanClient()
+users = client.group.get_all(limit=2)
+
+for user in users:
+    print(user)