Skip to content

Commit c6bfe3f

Browse files
vaibhavatlanAryamanz29
authored andcommitted
Small fix
1 parent c25ff48 commit c6bfe3f

File tree

4 files changed

+10
-17
lines changed

4 files changed

+10
-17
lines changed

pyatlan/client/atlan.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -854,7 +854,7 @@ def get_groups(
854854
def get_all_groups(
855855
self,
856856
limit: int = 20,
857-
) -> List[AtlanGroup]:
857+
) -> GroupResponse:
858858
"""Deprecated - use group.get_all() instead."""
859859
warn(
860860
"This method is deprecated, please use 'group.get_all' instead, which offers identical functionality.",
@@ -989,7 +989,7 @@ def get_users(
989989
def get_all_users(
990990
self,
991991
limit: int = 20,
992-
) -> List[AtlanUser]:
992+
) -> UserResponse:
993993
"""Deprecated - use user.get_all() instead."""
994994
warn(
995995
"This method is deprecated, please use 'user.get_all' instead, which offers identical functionality.",

pyatlan/model/workflow.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# SPDX-License-Identifier: Apache-2.0
22
# Copyright 2022 Atlan Pte. Ltd.
3-
from typing import Any, Dict, Generator, List, Optional
3+
from typing import Any, Dict, List, Optional
44

55
from pydantic.v1 import Field
66

testing.py

Lines changed: 0 additions & 7 deletions
This file was deleted.

tests/integration/admin_test.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,9 @@ def test_create_group(client: AtlanClient, group: CreateGroupResponse):
7272

7373
def test_retrieve_all_groups(client: AtlanClient, group: CreateGroupResponse):
7474
global _default_group_count
75-
groups = client.group.get_all()
75+
groups = client.group.get_all() # type: ignore
7676
assert groups
77-
assert len(groups) >= 1
77+
assert len(groups) >= 1 # type: ignore
7878
for group1 in groups:
7979
if group1.is_default():
8080
_default_group_count += 1
@@ -169,7 +169,7 @@ def test_retrieve_existing_user(client: AtlanClient, group: CreateGroupResponse)
169169
global _default_group_count
170170
all_users = client.user.get_all()
171171
assert all_users
172-
assert len(all_users) >= 1
172+
assert len(all_users) >= 1 # type: ignore
173173
user1 = client.user.get_by_username(FIXED_USER)
174174
assert user1
175175
assert user1.id
@@ -300,7 +300,7 @@ def test_get_all_with_limit(client: AtlanClient, group: CreateGroupResponse):
300300
limit = 2
301301
groups = client.group.get_all(limit=limit)
302302
assert groups
303-
assert len(groups) == limit
303+
assert len(groups) == limit # type: ignore
304304

305305
for group1 in groups:
306306
assert group1.id
@@ -313,7 +313,7 @@ def test_get_all_with_columns(client: AtlanClient, group: CreateGroupResponse):
313313
groups = client.group.get_all(columns=columns)
314314

315315
assert groups
316-
assert len(groups) >= 1
316+
assert len(groups) >= 1 # type: ignore
317317

318318
for group1 in groups:
319319
assert group1.name
@@ -326,7 +326,7 @@ def test_get_all_with_sorting(client: AtlanClient, group: CreateGroupResponse):
326326
groups = client.group.get_all(sort="name")
327327

328328
assert groups
329-
assert len(groups) >= 1
329+
assert len(groups) >= 1 # type: ignore
330330

331331
sorted_names = [group.name for group in groups if group.name is not None]
332332
assert sorted_names == sorted(sorted_names)
@@ -340,7 +340,7 @@ def test_get_all_with_everything(client: AtlanClient, group: CreateGroupResponse
340340
groups = client.group.get_all(limit=limit, columns=columns, sort=sort)
341341

342342
assert groups
343-
assert len(groups) == limit
343+
assert len(groups) == limit # type: ignore
344344
sorted_names = [group.name for group in groups if group.name is not None]
345345
assert sorted_names == sorted(sorted_names)
346346

0 commit comments

Comments
 (0)