[Bitbucket] Fix AssertionError error in pagination. (#653)

* [Bitbucket] Fix AssertionError error in pagination.

* Update test data.

* Fix default value for get_data.

* Consistence behavior of delete for OO interface.

* Fix tests.

Author: Spacetown

atlassian/bitbucket/base.py

@@ -38,15 +38,7 @@ def _get_paged(self, url, params=None, data=None, flags=None, trailing=None, abs
             if "values" not in response:
                 return
 
-            values = response.get("values", [])
-            if not response.get("size", -1) == len(values):
-                raise AssertionError(
-                    "Wrong response for url [{}], the size attribute doesn't match the number of recieved values:\n{}".format(
-                        self.url, response
-                    )
-                )
-
-            for value in values:
+            for value in response.get("values", []):
                 yield value
 
             if self.cloud:

atlassian/bitbucket/cloud/base.py

@@ -58,15 +58,7 @@ def _get_paged(self, url, params=None, data=None, flags=None, trailing=None, abs
             if "values" not in response:
                 return
 
-            values = response.get("values", [])
-            if not response.get("size", -1) == len(values):
-                raise AssertionError(
-                    "Wrong response for url [{}], the size attribute doesn't match the number of recieved values:\n{}".format(
-                        self.url, response
-                    )
-                )
-
-            for value in values:
+            for value in response.get("values", []):
                 yield value
 
             url = response.get("next")
@@ -88,8 +80,8 @@ def update(self, **kwargs):
     def data(self):
         return copy.copy(self.__data)
 
-    def get_data(self, id):
-        return copy.copy(self.__data[id])
+    def get_data(self, id, default=None):
+        return copy.copy(self.__data[id]) if id in self.__data else default
 
     def get_link(self, link):
         return self.__data["links"][link]["href"]

atlassian/bitbucket/cloud/repositories/branchRestrictions.py

@@ -144,6 +144,6 @@ def delete(self):
         Deletes the branch restriction
         """
         data = super(BranchRestriction, self).delete(None)
-        if "errors" in data:
+        if data is None or "errors" in data:
             return
         return BranchRestriction(data, **self._new_session_args)

atlassian/bitbucket/cloud/repositories/defaultReviewers.py

@@ -95,6 +95,6 @@ def delete(self):
         Deletes the default reviewer
         """
         data = super(DefaultReviewer, self).delete(None)
-        if "errors" in data:
+        if data is None or "errors" in data:
             return
         return DefaultReviewer(self.url, data, **self._new_session_args)

atlassian/bitbucket/cloud/repositories/issues.py

@@ -128,6 +128,6 @@ def delete(self):
         Deletes the issue
         """
         data = super(Issue, self).delete(None)
-        if "errors" in data:
+        if data is None or "errors" in data:
             return
         return Issue(data, **self._new_session_args)

atlassian/bitbucket/cloud/workspaces/projects.py

@@ -151,4 +151,7 @@ def delete(self):
         """
         Delete the project
         """
-        return super(Project, self).delete(None)
+        data = super(Project, self).delete(None)
+        if data is None or "errors" in data:
+            return
+        return data

atlassian/bitbucket/server/base.py

@@ -59,15 +59,7 @@ def _get_paged(self, url, params=None, data=None, flags=None, trailing=False, ab
             if "values" not in response:
                 return
 
-            values = response.get("values", [])
-            if not response.get("size", -1) == len(values):
-                raise AssertionError(
-                    "Wrong response for url [{}], the size attribute doesn't match the number of recieved values:\n{}".format(
-                        self.url, response
-                    )
-                )
-
-            for value in values:
+            for value in response.get("values", []):
                 yield value
 
             if response.get("nextPageStart") is None:
@@ -100,16 +92,16 @@ def delete(self):
         if self.__can_delete is False:
             raise NotImplementedError("Delete not implemented for this object type.")
         data = super(BitbucketServerBase, self).delete(None)
-        if "errors" in data:
+        if data is None or "errors" in data:
             return
         return True
 
     @property
     def data(self):
         return copy.copy(self.__data)
 
-    def get_data(self, id):
-        return copy.copy(self.__data[id])
+    def get_data(self, id, default=None):
+        return copy.copy(self.__data[id]) if id in self.__data else default
 
     def get_link(self, link):
         return [x["href"] for x in self.__data["links"][link]]

atlassian/bitbucket/server/common/__init__.py

@@ -159,7 +159,7 @@ def delete(self):
         if self.url is None:
             raise NotImplementedError("Delete not implemented for this object type.")
         data = super(BitbucketServerBase, self).delete(None, params={"name": self.name})
-        if "errors" in data:
+        if data is None or "errors" in data:
             return
         return True
 
@@ -180,7 +180,6 @@ def __init__(self, data, *args, **kwargs):
         super(User, self).__init__(None, *args, data=data, **kwargs)
 
     def __userdata(self, key):
-        print(self.__dict__)
         if self.url is None:
             return self.get_data(key)
         return self.get_data("user")[key]

atlassian/bitbucket/server/globalPermissions.py

@@ -156,7 +156,7 @@ def delete(self):
         if self.url is None:
             raise NotImplementedError("Delete not implemented for this object type.")
         data = super(BitbucketServerBase, self).delete(None, params={"name": self.name})
-        if "errors" in data:
+        if data is None or "errors" in data:
             return
         return True
 

tests/responses/bitbucket/cloud/2.0/repositories/TestWorkspace1/testrepository1/pipelines/{PipelineUuid}/GET

@@ -50,7 +50,6 @@ responses[None] = {
         "account_id": "OwnerTestWorkspace1AccountId",
     },
     "created_on": "2020-11-03T22:14:50.671Z",
-    "completed_on": "2020-11-03T22:14:53.173Z",
     "target": {
         "type": "pipeline_ref_target",
         "ref_type": "branch",