mypy fixes

Author: bandophahita

atlassian/confluence.py

@@ -5,6 +5,7 @@
 import os
 import re
 import time
+from typing import cast
 
 import requests
 from bs4 import BeautifulSoup
@@ -2747,7 +2748,7 @@ def get_atl_request(url: str):
             try:
                 response = self.get(url, advanced_mode=True)
                 parsed_html = BeautifulSoup(response.text, "html.parser")
-                atl_token = parsed_html.find("input", {"name": "atl_token"}).get("value")
+                atl_token = parsed_html.find("input", {"name": "atl_token"}).get("value")  # type: ignore[union-attr]
                 return atl_token
             except Exception as e:
                 raise ApiError("Problems with getting the atl_token for get_space_export method :", reason=e)
@@ -2799,17 +2800,18 @@ def get_atl_request(url: str):
             parsed_html = BeautifulSoup(response.text, "html.parser")
             # Getting the poll URL to get the export progress status
             try:
-                poll_url = parsed_html.find("meta", {"name": "ajs-pollURI"}).get("content")
+                poll_url = cast("str", parsed_html.find("meta", {"name": "ajs-pollURI"}).get("content"))  # type: ignore[union-attr]
             except Exception as e:
                 raise ApiError("Problems with getting the poll_url for get_space_export method :", reason=e)
             running_task = True
             while running_task:
                 try:
                     progress_response = self.get(poll_url)
+                    assert progress_response
                     log.info("Space" + space_key + " export status: " + progress_response["message"])
                     if progress_response["complete"]:
                         parsed_html = BeautifulSoup(progress_response["message"], "html.parser")
-                        download_url = parsed_html.find("a", {"class": "space-export-download-path"}).get("href")
+                        download_url = cast("str", parsed_html.find("a", {"class": "space-export-download-path"}).get("href"))  # type: ignore
                         if self.url in download_url:
                             return download_url
                         else:

atlassian/jira.py

@@ -302,7 +302,7 @@ def download_attachments_from_issue(
         except Exception as e:
             raise e
 
-    def get_attachment_content(self, attachment_id: T_id) -> T_resp_json:
+    def get_attachment_content(self, attachment_id: T_id) -> bytes:
         """
         Returns the content for an attachment
         :param attachment_id: int
@@ -1791,7 +1791,7 @@ def get_issue_remote_links(
             url += "/" + internal_id
         return self.get(url, params=params)
 
-    def get_issue_tree_recursive(self, issue_key: str, tree: list = None, depth: int = None):
+    def get_issue_tree_recursive(self, issue_key: str, tree: Optional[list] = None, depth: Optional[int] = None):
         """
         Returns a list that contains the tree structure of the root issue, with all subtasks and inward linked issues.
         (!) Function only returns child issues from the same Jira instance or from an instance to which the API key has access.

atlassian/rest_client.py

@@ -168,7 +168,7 @@ def __init__(
         else:
             self._session = session
 
-        if proxies is not None:
+        if self.proxies is not None:
             self._session.proxies = self.proxies
 
         if self.backoff_and_retry and self.use_urllib3_retry: