Fix paging when querying Jira via JQL (#939)

* Jira: Implement paging in Jira.jql

* Jira: Use paging to get all commits in get_commits

Author: ilmagico

atlassian/bitbucket/__init__.py

@@ -2023,7 +2023,7 @@ def get_commits(
             params["avatarScheme"] = avatar_scheme
         if limit:
             params["limit"] = limit
-        return (self.get(url, params=params) or {}).get("values")
+        return self._get_paged(url, params=params)
 
     def _url_commit(self, project_key, repository_slug, commit_id, api_root=None, api_version=None):
         return "{}/{}".format(

atlassian/jira.py

@@ -2590,8 +2590,6 @@ def jql(self, jql, fields="*all", start=0, limit=None, expand=None, validate_que
         :return:
         """
         params = {}
-        if start is not None:
-            params["startAt"] = int(start)
         if limit is not None:
             params["maxResults"] = int(limit)
         if fields is not None:
@@ -2605,7 +2603,24 @@ def jql(self, jql, fields="*all", start=0, limit=None, expand=None, validate_que
         if validate_query is not None:
             params["validateQuery"] = validate_query
         url = self.resource_url("search")
-        return self.get(url, params=params)
+
+        results = []
+        while True:
+            params["startAt"] = int(start)
+            response = self.get(url, params=params)
+            if not response:
+                break
+
+            issues = response["issues"]
+            results.extend(issues)
+            total = int(response["total"])
+            # #print("DBG: response: total={total} start={startAt} max={maxResults}".format(**response))
+            # If we don't have a limit, and there's more to fetch, keep looping
+            if limit is not None or total <= len(response["issues"]) + start:
+                break
+            start += len(issues)
+
+        return results
 
     def csv(self, jql, limit=1000, all_fields=True, start=None, delimiter=None):
         """