Skip to content

Commit b7e8792

Browse files
author
Gonchik Tsymzhitov
committed
Jira: fix the #578 request
1 parent 01d0b9e commit b7e8792

File tree

1 file changed

+20
-9
lines changed

1 file changed

+20
-9
lines changed

atlassian/jira.py

Lines changed: 20 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1155,27 +1155,31 @@ def get_worklogs(self, ids, expand=None):
11551155
Reference: https://docs.atlassian.com/software/jira/docs/api/REST/8.5.0/#api/2/user
11561156
"""
11571157

1158-
def user(self, username=None, key=None, expand=None):
1158+
def user(self, username=None, key=None, account_id=None, expand=None):
11591159
"""
11601160
Returns a user. This resource cannot be accessed anonymously.
11611161
You can use only one parameter: username or key
11621162
11631163
:param username:
11641164
:param key: if username and key are different
1165+
:param account_id:
11651166
:param expand: Can be 'groups,applicationRoles'
11661167
:return:
11671168
"""
11681169
params = {}
1170+
major_parameter_enabled = False
1171+
if account_id:
1172+
params = {"accountId": account_id}
1173+
major_parameter_enabled = True
11691174

1170-
if username and not key:
1175+
if not major_parameter_enabled and username and not key:
11711176
params = {"username": username}
1172-
elif not username and key:
1177+
elif not major_parameter_enabled and not username and key:
11731178
params = {"key": key}
1174-
elif username and key:
1179+
elif not major_parameter_enabled and username and key:
11751180
return "You cannot specify both the username and the key parameters"
1176-
elif not username and not key:
1177-
return "You must specify at least one parameter: username or key"
1178-
1181+
elif not account_id and not key and not username:
1182+
return "You must specify at least one parameter: username or key or account_id"
11791183
if expand:
11801184
params["expand"] = expand
11811185

@@ -1189,13 +1193,20 @@ def is_active_user(self, username):
11891193
"""
11901194
return self.user(username).get("active")
11911195

1192-
def user_remove(self, username):
1196+
def user_remove(self, username=None, account_id=None, key=None):
11931197
"""
11941198
Remove user from Jira if this user does not have any activity
11951199
:param username:
11961200
:return:
11971201
"""
1198-
return self.delete("rest/api/2/user?username={0}".format(username))
1202+
params = {}
1203+
if username:
1204+
params["username"] = username
1205+
if account_id:
1206+
params["accountId"] = account_id
1207+
if key:
1208+
params["key"] = key
1209+
return self.delete("rest/api/2/user", params=params)
11991210

12001211
def user_update(self, username, data):
12011212
"""

0 commit comments

Comments
 (0)