Skip to content

Commit e2eec8b

Browse files
authored
[BitBucket] Fix get_project_tags. (#829)
If tag_name is given a single tag is returned, else a generator for the tags (paged API)
1 parent 2de3e26 commit e2eec8b

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

atlassian/bitbucket/__init__.py

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1200,7 +1200,7 @@ def get_tags(
12001200
params["orderBy"] = order_by
12011201
return self._get_paged(url, params=params)
12021202

1203-
def get_project_tags(self, project_key, repository_slug, tag_name):
1203+
def get_project_tags(self, project_key, repository_slug, tag_name=None):
12041204
"""
12051205
Retrieve a tag in the specified repository.
12061206
The authenticated user must have REPO_READ permission for the context repository to call this resource.
@@ -1211,7 +1211,10 @@ def get_project_tags(self, project_key, repository_slug, tag_name):
12111211
:return:
12121212
"""
12131213
url = self._url_repo_tags(project_key, repository_slug)
1214-
return self.get(url)
1214+
if tag_name is not None:
1215+
return self.get("{}/{}".format(url, tag_name))
1216+
1217+
return self._get_paged(url)
12151218

12161219
def set_tag(self, project_key, repository_slug, tag_name, commit_revision, description=None):
12171220
"""
@@ -1225,13 +1228,13 @@ def set_tag(self, project_key, repository_slug, tag_name, commit_revision, descr
12251228
:return:
12261229
"""
12271230
url = self._url_repo_tags(project_key, repository_slug)
1228-
body = {}
1229-
if tag_name is not None:
1230-
body["name"] = tag_name
1231-
if tag_name is not None:
1232-
body["startPoint"] = commit_revision
1233-
if tag_name is not None:
1231+
body = {
1232+
"name": tag_name,
1233+
"startPoint": commit_revision,
1234+
}
1235+
if description is not None:
12341236
body["message"] = description
1237+
12351238
return self.post(url, data=body)
12361239

12371240
def delete_tag(self, project_key, repository_slug, tag_name):
@@ -1247,7 +1250,6 @@ def delete_tag(self, project_key, repository_slug, tag_name):
12471250
self._url_repo_tags(project_key, repository_slug, api_root="rest/git"),
12481251
tag_name,
12491252
)
1250-
(project_key, repository_slug, tag_name)
12511253
return self.delete(url)
12521254

12531255
def _url_repo_hook_settings(self, project_key, repository_slug):

0 commit comments

Comments
 (0)